Use dumb-init to correctly forward shutdown signals to gremlin-server

bricaud / gremlin-server

A Docker container with a gremlin server

MIT License

27 stars 19 forks source link

Closed kristallizer closed 5 years ago

kristallizer commented 5 years ago

Closes bricaud/gremlin-server#6

kristallizer commented 5 years ago

Hey @bricaud can you please review and let me know if you'd like to merge these changes?

bricaud commented 5 years ago

Thanks @kristallizer ! Sorry I was not responsive, I am jut back from holidays.

Why do you redirect SIGTERM to SIGQUIT ? I had a quick look but I did not find any doc about which signal to use with the Gremlin server.

kristallizer commented 5 years ago

@bricaud thanks! I'm redirecting SIGTERM to SIGINT since that's what gremlin-server is expecting to get to trigger a graceful shutdown.

kristallizer commented 5 years ago

@bricaud can you also push the latest build to Docker Hub?

bricaud commented 5 years ago

ok it should be available with the "latest" version on Dockerhub.

I got it now for the SIGINT signal, which is equivalent to use ctrl-c to stop the server. Thanks a lot!

kristallizer commented 5 years ago

🚀