Few Things

[foxmask]

Hi,

I've tested and it's really cool ;)

Here is 2 suggestions :

• in your README you can add to check that in the defaultconfig.ini.php that the pluginsPath var is correctly set ;)
• you read the gjConfig, but sooner or later the global var will desappear, thus the plugin should use jApp::* no ?

[bricet]

Thanks for your testing ! It's not a really awesome plugin, but can be usefull for fast debugging ... please do not over-consider it ;))

Regarding your suggestions :

• I will do that. Thanks
• I suppose we should wait before using jApp::config() because this appears in Jelix 1.4 whereas the debugbar appeared in 1.3. And 1.4 is still backward compatible with $gJConfig, if I remember well. So this seems a little early to use it already, to my mind ...

[foxmask]

Hi,

in fact it's not really early ;)

• https://github.com/foxmask/Booster/blob/master/lib/jelix/VERSION
• https://github.com/foxmask/Booster/blob/master/booster/application.init.php

all of this to explain that $gJConfig will be deprecated in 1.3.x

Regards.

[bricet]

I just do not understand. jApp appeared in 1.3 but jApp::config() in 1.4 :

• https://github.com/foxmask/Booster/blob/master/lib/jelix/core/jApp.class.php -> can't see a config() method
• http://jelix.org/articles/en/changelog/1.4 : "new jApp::config() method, to retrieve the configuration. $gJConfig is deprecated"
• more "official" ;) : https://github.com/jelix/jelix/blob/jelix-1.3.x/lib/jelix/core/jApp.class.php / https://github.com/jelix/jelix/blob/master/lib/jelix/core/jApp.class.php -> config() method only in master, not on 1.3.x branch

So IMHO calling jApp::config() will not work in 1.3 (neither will it in any 1.3.x, if I understand well) but will in 1.4. This seems quite logical to me : such a big change only occurs in main releases, not sub-releases.

[foxmask]

u r right ! :)

[bricet]

Finally solved with https://github.com/bricet/jelix-techinfo-debugbar/pull/2 ;)