Add LocalDateRange::isIntersect method

brick / date-time

Date and time library for PHP

MIT License

335 stars 30 forks source link

Closed solodkiy closed 4 years ago

solodkiy commented 4 years ago

New methods

LocalDateRange::isIntersect() returns whether this LocalDateRange intersect with the given date range.
LocalDateRange::getIntersection() returns intersection this LocalDateRange with the given date range, exception if ranges do not intersect

BenMorel commented 4 years ago

Hi, thanks for your PR, looks good to me!

I just don't like the naming isIntersect() very much, I'd prefer intersectsWith(), which makes the interface fluent, just like isEqualTo().

solodkiy commented 4 years ago

ok. What about getIntersection? Should we change it to getIntersectionWith?

BenMorel commented 4 years ago

Makes sense, I guess. Go ahead! 👍

solodkiy commented 4 years ago

Done.

BenMorel commented 4 years ago

Thank you, released as 0.2.1!