search

brick / date-time

Date and time library for PHP
MIT License
335 stars 30 forks source link

Rename LocalDateRange::getStart() / getEnd() #37

Open BenMorel opened 3 years ago

BenMorel commented 3 years ago

to getStartDate() / getEndDate(). Will require a version bump.

BenMorel commented 3 years ago

Oops, this was already like this before, and was changed in #13, for consistency with YearMonthRange::getStart() / getEnd().

Not sure what the best move is here.

jurchiks commented 3 years ago

Should have deprecated the non-*Date methods in YearMonthRange instead of removing the suffix from the LocalDateRange methods.