Align with PHP terminology (breaking change)

brick / date-time

Date and time library for PHP

MIT License

335 stars 30 forks source link

Align with PHP terminology (breaking change) #40

Closed morrislaptop closed 2 years ago

morrislaptop commented 2 years ago

In PHP land

DateInterval - A date interval stores either a fixed amount of time (in years, months, days, hours etc)
DatePeriod - Represents a date period (start date, end date)

In Brick land

Interval - a period of time between two instants (start, end)
Period - a date-based amount of time, such as '2 years, 3 months and 4 days'

Would you be open to swapping the names around to align with PHP? (I can't even extend to rename because the classes are final)

BenMorel commented 2 years ago

Hi, the aim of this library is not to align with PHP's date-time library (which I consider poorly designed, for the record), but to model after Java's time library, which it was originally a port of.

Therefore, this is not a direction I'm going to follow ;-)