search

brick / date-time

Date and time library for PHP
MIT License
323 stars 29 forks source link

LocalDateRange::toNativeDatePeriod #56

Closed solodkiy closed 2 years ago

solodkiy commented 2 years ago

LocalDateRange::toNativeDatePeriod

https://github.com/brick/date-time/issues/47

BenMorel commented 2 years ago

LGTM, could you please update the CHANGELOG? And in #57 and #58 as well.

solodkiy commented 2 years ago

@BenMorel I tried to use same emoji, but I cannot see it in macos. Maybe we should use old good plain text instead?

image image
BenMorel commented 2 years ago

@solodkiy It's a Unicode character that I thought would be quite universal: https://unicode-table.com/en/1F872/

Feel free to replace with another arrow that works for you: https://unicode-table.com/en/sets/arrow-symbols/, or just with -> if you still have trouble (please replace the others as well for consistency).

solodkiy commented 2 years ago

Changed to U+2192

BenMorel commented 2 years ago

Thanks :+1: