search

brick / date-time

Date and time library for PHP
MIT License
323 stars 29 forks source link

Bring back support for sub-minute offsets in PHP >= 8.1.7 #60

Closed jiripudil closed 1 year ago

jiripudil commented 2 years ago

closes #44

BenMorel commented 1 year ago

By the way, regarding the workaround for DateTimeZone::getName() omitting seconds, I created an issue with PHP:

https://github.com/php/php-src/issues/11281

jiripudil commented 1 year ago

Hi, thanks, I've fixed the nitpicks and rebased the branch.

Also it seems that the issue has been fixed already (https://github.com/php/php-src/commit/f9117eb82487a0566c8fee3fda798cc2eb969d4a), so I've updated the workaround to only apply in affected PHP versions.

BenMorel commented 1 year ago

Thank you, @jiripudil !

BenMorel commented 1 year ago

Released in 0.4.3.