Implement contains, intersection and `of` methods for Interval

brick / date-time

Date and time library for PHP

MIT License

334 stars 30 forks source link

Implement contains, intersection and `of` methods for Interval #64

Closed someniatko closed 1 year ago

someniatko commented 2 years ago

closes #63

someniatko commented 2 years ago

Do you think it makes sense to also implement isEqualTo() and toNativeDatePeriod()?

someniatko commented 1 year ago

@BenMorel ping 🤸

BenMorel commented 1 year ago

Do you think it makes sense to also implement isEqualTo() and toNativeDatePeriod()?

isEqualTo(): yes, and you may use it in your tests as per my comment
toNativeDatePeriod(): it looks like DatePeriod is about recurring periods, so I don't think they represent the same concept. I'd pass on this one.

someniatko commented 1 year ago

Okay, I will implement isEqualTo() as well.

someniatko commented 1 year ago

Done! Code coverage has been decreased for the classes this PR is not responsible for, maybe something has changed in the method of the coverage calculation.

BenMorel commented 1 year ago

Thank you! Released as 0.4.2 :tada: