search

brick / math

Arbitrary-precision arithmetic library for PHP
MIT License
1.83k stars 78 forks source link

[ECS] Init #54

Closed TomasVotruba closed 3 years ago

TomasVotruba commented 3 years ago

Hey,

I've added GitHub Action, but it's not enabled here yet. Could you enable it so we can see results?

TomasVotruba commented 3 years ago

Btw, have you considered switching to GitHub Actions? The Travis is super slow... still waiting on feedback :/

BenMorel commented 3 years ago

Thanks for the PR! I'm OK with removing the space between the closing parentheses and colon, however I'd like to preserve the aligned equal signs and @params, is this possible? This is actually one of the few things that put me off when I tried ECS lately, I couldn't find a SetList that would work for me!

TomasVotruba commented 3 years ago

I haven't seen it such coding standard for a while, but I can try to ignore it. ECS is handling most of the rules in a commonly used way.

TomasVotruba commented 3 years ago

Could you enable GitHub Actions first, so we have a feedback from CI if coding standard passes.

BenMorel commented 3 years ago

I'm new to GH actions, so I'd prefer if we can add it in a separate PR first!

BenMorel commented 3 years ago

I was reluctant at first regarding GH actions, because of the limits for open-source repos; but it sounds like Travis is becoming worse than that, so maybe now is the time to make the switch indeed.

TomasVotruba commented 3 years ago

I can't validate it without Github Actions.

I was reluctant at first regarding GH actions, because of the limits for open-source repos;

Huh, where is that information from? It's unlimited for open-source. We use it for a year on 10 projects with 20-30 pipelines each.

Travis is putting limit on open-source, closing down since November.


I can't validate if the code works or not without CI so I'm forced to close this PR for now. Let me know when you've migrated to GitHub Actions.

BenMorel commented 3 years ago

This info comes from #45, but I haven't had a chance to verify it!

BenMorel commented 3 years ago

So it looks like you're right, I think the confusion came from the "GitHub Free" > 2,000 minutes per month. But as I understand it, this applies to private repos in the Free plan, not to public repos.

Do you want to help with migrating to GH actions by opening a PR to replicate the Travis config on GH?

TomasVotruba commented 3 years ago

I was about to only add ECS. Any other work is out of my free capacity.

BenMorel commented 3 years ago

I just moved the CI to GitHub Actions; I didn't have to enable anything though, do you think that the repo needed one workflow committed to start building workflows in PRs?

TomasVotruba commented 3 years ago

I'm sorry, I'm out of free time for this operation. It took more than I've expected. But you can copy the PR here and merge it locally. The work is done.

BenMorel commented 3 years ago

The work is done.

It's not, as far as I'm concerned: it's changing the current CS in a way that I think is detrimental to readability (un-aligning equal signs & @params). But thanks anyway.