search

brick / math

Arbitrary-precision arithmetic library for PHP
MIT License
1.78k stars 75 forks source link

ECS+Rector+CI/CD rules #71

Closed Spomky closed 2 years ago

Spomky commented 2 years ago

THis PR adds ECS (see #44) and Rector to ease mainting coding standards and allowing to upgrade to newer PHP version in a smooth way. In addition, two workflows are added to help detecting new PRs where modifications could be improved.

Note that the proposed rules are highly opiniated. If you disagree with one or the other, I will be happy to revert it.

tigitz commented 2 years ago

Hello, we're in the process of standardizing the ci checks for every brick organization projects with @BenMorel

You can check https://github.com/brick/date-time/pull/62

And https://github.com/brick/coding-standards/pull/2

I won't get back to it until end of this month but if you want to team up with me and push forward those topics feel free. I'll be happy to help.

Spomky commented 2 years ago

Excellent! That's a good one I missed. So let close this PR in favor of the one you pointed out