brick / money

A money and currency library for PHP
MIT License
1.65k stars 102 forks source link

Goodbye manual Composer file editing #8

Closed raphaelstolt closed 7 years ago

raphaelstolt commented 7 years ago

Let Composer modify the composer.json and resolve the library it's latest version.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling f0bf76f8b3288ad6b95ee314712f4526af6c7e88 on raphaelstolt:patch-1 into 0b1d0100a29a26c46a2fe26d2f5d8062922ed239 on brick:master.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling f0bf76f8b3288ad6b95ee314712f4526af6c7e88 on raphaelstolt:patch-1 into 0b1d0100a29a26c46a2fe26d2f5d8062922ed239 on brick:master.

BenMorel commented 7 years ago

I'd like to keep the existing JSON and wording, but feel free to just add right after the JSON:


Or just run:

composer require brick/money

raphaelstolt commented 7 years ago

I get your point regarding the wording change, but keeping the JSON is obsolete for two reasons:

So there's not really a case for an or in it.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 06c573793f233c7595526cae13771e74f1b1c532 on raphaelstolt:patch-1 into 0b1d0100a29a26c46a2fe26d2f5d8062922ed239 on brick:master.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 06c573793f233c7595526cae13771e74f1b1c532 on raphaelstolt:patch-1 into 0b1d0100a29a26c46a2fe26d2f5d8062922ed239 on brick:master.

BenMorel commented 7 years ago

I don't know about that, I always prefer to keep an eye on my composer.json version constraints manually. Updating the version in the README is not a big deal!

Please keep it as it is for now, but you can add the composer require first:

Just run: composer require brick/money or manually define the following requirement in your composer.json file: ...

BenMorel commented 7 years ago

👍