search

brick / money

A money and currency library for PHP
MIT License
1.61k stars 96 forks source link

Keep releases lean #9

Closed raphaelstolt closed 6 years ago

raphaelstolt commented 6 years ago

Keep unnecessary files out of releases/dists. If you want to ship the license file remove it's export-ignore.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 0674bf2b759b186e5bc40d28388abd8e5ba8eb32 on raphaelstolt:lean-releases into 0b1d0100a29a26c46a2fe26d2f5d8062922ed239 on brick:master.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 0674bf2b759b186e5bc40d28388abd8e5ba8eb32 on raphaelstolt:lean-releases into 0b1d0100a29a26c46a2fe26d2f5d8062922ed239 on brick:master.

BenMorel commented 6 years ago

👍 Please don't export-ignore the license file, and I'll merge it!

BenMorel commented 6 years ago

And please add export-ignore for import-currencies.php as mentioned in #10!

raphaelstolt commented 6 years ago

IMO it shouldn't be export ignored, so that a library user can import / update currencies independently from the maintainer; given that this data changes frequently.

Scratch that after reading your comment on #10.

BenMorel commented 6 years ago

Looks good, thanks!