brickbots / PiFinder

A plate solving telescope finder based around a Raspberry PI and RPI HQ Camera
GNU General Public License v3.0
158 stars 30 forks source link

scroll_object in ui/object_details.py gets passed weird stuff #225

Open jscheidtmann opened 1 month ago

jscheidtmann commented 1 month ago

See https://github.com/brickbots/PiFinder/pull/222/files#r1732015625

Need to investigate where this is coming from. brickbots wrote: "[it] might be nice to figure out where this is coming from. I'm guess it's a side effect of the nearby sort?"

mrosseel commented 1 month ago

Nearby sorting is using numpy for speed, we should either use numpy for all sorting stuff or convert nearby sort to normal list. I'm currently reworking sorting so it's probably best to revisit this after the sorting changes are done. (my PR will set default sorting orders for each menu item, and probably allow the user to override them in the settings)