search

bricke / Qt-AES

Native Qt AES encryption class
The Unlicense
501 stars 187 forks source link

Fixed invShiftRows in Shift 3 #30

Closed evilyach closed 4 years ago

evilyach commented 4 years ago

This must be broken. The indices of iterable inside shift 3 seem random and do not correspond to the AES algorighm. More than that, it should be reversed from shiftRows methods, and shifts 1 and 2 seem normal.

bricke commented 4 years ago

Hi, thank you for the PR, I will check it and let you know

bricke commented 4 years ago

I see what you mean. I'll accept this change, it's the same content in the same spots but yours matches the shiftRows method, it's cleaner that way