search

brickfield / moodle-block_accessibility

Accessibility tools for Moodle, including ATbar from Southapton University ECS
19 stars 34 forks source link

Block version for moodle 2.8 #81

Closed jordelca closed 9 years ago

jordelca commented 9 years ago

Hi, have been working with this block for moodle 2.7. I just updated my moodle to 2.8, and I realized that it doesn't work as expected. Is that a known issue? is there any quickfix?

Is there any scheduled deadline for the new version to be published? regards Jorge

hrvojegolcic commented 9 years ago

Hi! Thank you for your your feedback. In a week or two I should be able to resolve the compatibility issue. Will post back here soon.

On 16 December 2014 at 13:10, jordelca notifications@github.com wrote:

Hi, have been working with this block for moodle 2.7. I just updated my moodle to 2.8, and I realized that i doesn't work as expected. Is that a known issue? is there any quickfix?

Is there any scheduled deadline for the new version to be published? regards Jorge

— Reply to this email directly or view it on GitHub https://github.com/marxjohnson/moodle-block_accessibility/issues/81.

jordelca commented 9 years ago

Hi again! any news about this issue? just asking, no hurries. Thanks

hrvojegolcic commented 9 years ago

In my case it doesn't work at all in 2.8. I'm still unable to resolve what would be the reason. Will come back with a solution as soon I succeed. Should take a few weeks more I guess as now I'm on holidays. Do you have any idea as well?

On 5 January 2015 at 13:14, jordelca notifications@github.com wrote:

Hi again! any news about this issue? just asking, no hurries. Thanks

— Reply to this email directly or view it on GitHub https://github.com/marxjohnson/moodle-block_accessibility/issues/81#issuecomment-68700474 .

jordelca commented 9 years ago

Hi again, I think I found the problem. Css are loaded with content type: "text/html". Although the content type is initially set to "text/css", for some reason it is set back to "text/html" after config.php call. So I fixed it by moving config.php call to first line, so that once header is set content type is not modified. Would that be a valid fix? You dont need to answer right now, enjoy your holidays!

hrvojegolcic commented 9 years ago

Wow! Was it really that simple? :P Well many thanks to you for noticing it. I really appreciate it. Content type is actually what causes bug in older versions of IE as well. I Did't notice so far.

I guess the best fix would be to change .php extension to .css extension as well because it only leads to confusion to people and browsers, wouldn't you agree? But then the server would need to be configured properly which is less likely

In few days I'll include a few more bugfixes and publish a new release. Thanks a lot once more for your contribution!

hrvojegolcic commented 9 years ago

During the day I'll publish a new version of a block (2.2.2) to a Moodle plugin repository. Thanks for everything

jordelca commented 9 years ago

Great! You are welcome, Im glad was able to help!