brickviking / Dolphin

Dolphin Smalltalk Help
https://object-arts.com
MIT License
0 stars 0 forks source link

[Wine] bootInfo shows extra unrendered character 0x0A #17

Open brickviking opened 4 years ago

brickviking commented 4 years ago

Le Bug When Dolphin builds an image, git is run in an external process to fetch the relevant git version for that release. This is run from SessionManager current stashBootInfo. A string is returned that contains a linefeed character at the end. Under Windows, when the window is displayed, the LF is simply ignored, however under Wine, the extra character shows up as an unrendered square, as if the font has no glyph to represent it.

To Reproduce Steps to reproduce the behaviour: 1: Boot up Windows, open a shell, clone the Dolphin repo, change to Dolphin's directory. 1a: fetch the VM. FetchVM.cmd should do this for you. 1b: create a DPRO image. BootDPRO.cmd should do this for you. 2: In the shell, run Dolphin7 DBOOT.img7 DolphinProfessional 3: An image will be created. Run it as usual. 4: The title for the system folder will have a git version appended to it if you have Git installed under Windows.

  1. Copy this to a Linux distribution. Boot up Dolphin under wine, using the same DPRO.img7 image generated by the build process. The title bar of the system folder shows an extra character appended to the git version string. Also note what happens when you paste the first two lines into a Workspace and run DoIt on each line.

[code] Transcript show: SessionManager current bootInfo; cr; show: '=== Delimiter==='. SessionManager current bootInfo. is added to show the extra gap. 'v7.1.10-37-gd129ebfd *** '

Transcript output: v7.1.10-37-gd129ebfd

== Delimiter === [/code]

Note the extra linefeed after the version.

Expected behaviour The Linefeed shouldn't be visible, or should be removed from the bootInfo member of the productDetail array.

Screenshots If applicable, add screenshots to help explain your problem.

Please complete the following information):