brickviking / Dolphin

Dolphin Smalltalk Help
https://object-arts.com
MIT License
0 stars 0 forks source link

"Close" window menu entry missing from View Browser window #22

Open brickviking opened 3 years ago

brickviking commented 3 years ago

Describe the bug Opening a View Browser and checking the View menu doesn't show a "Close    Alt-F4" line at the bottom, though Alt-F4 closes the window fine.

To Reproduce Steps to reproduce the behaviour:

  1. Open View Browser from the System Folder.
  2. Click on View menu
  3. Scroll down to bottom
  4. No "Close Window" entry.

Expected behaviour A Close Window entry should be in the menu of all relevant windows, as Alt-F4 is a global keybinding honoured by all windows in Dolphin Smalltalk. I would normally argue for the use of Ctl-W but Alt-F4 has been around since at least Dolphin-4.

Screenshots If applicable, add screenshots to help explain your problem.

Please complete the following information):

brickviking commented 3 years ago

Some further information

Tally of Dolphin windows that have "Close" (or something else similar):

Tally of windows that don't have "Close":

Items to think about

  1. First, do the windows need to have Alt-F4 specifically mentioned in all cases where there is a relevant menu? The key shortcut is globally implemented.
  2. If so, what needs to be edited? The resource_Default_View? If that's the case, that's a biggish job.
  3. If a class needs to be modified (perhaps the relevant menu code for each window), how easy is it to do that? Should be easy.