bricolages / bricolage

AWS-oriented Data Warehouse Framework
114 stars 20 forks source link

Relax version constraint of pg gem #176

Closed nekketsuuu closed 1 year ago

nekketsuuu commented 1 year ago

In order to use bricolage with Ruby 3.2, we need pg >= 1.3.0: https://github.com/ged/ruby-pg/issues/413 Also, pg 1.4.0 and 1.4.1 fixes issues around keyword argument warnings on Ruby 2.7: https://github.com/ged/ruby-pg/blob/master/History.md#v141-2022-06-24-lars-kanis-larsgreiz-reinsdorfde

It seems there are no reasons to limit pg to '< 1.3', so I relax the current requirements to '>= 1.2.3' and '< 2'.


Also, I would appreciate if you could release a new version (6.0.0beta7?) of bricolage in order to use new bricolage by other gems.

aamine commented 1 year ago

I'll release bricolage 6.0.0beta7, but how do you think about you get release privilege? I'm willing to attach release privilege to all members of Cookpad SRE members.

nekketsuuu commented 1 year ago

@aamine Thanks! It sounds good to me to receive release privilege. Would you please attach it to https://rubygems.org/profiles/nekketsuuu? I'll attach the privilege to other Cookpad SRE members if necessary.

Also, is it OK to give me maintenance privilege of this repository? I may merge a pull request when releasing a new version of bricolage.

aamine commented 1 year ago

@nekketsuuu Sorry for delay, I have released bricolage 6.0.0beta7. Also, added you as a bricolage gem owner and bricolages organization admin. Feel free to add other Cookpad tech-dept members to both.

nekketsuuu commented 1 year ago

Thank you very much! I confirmed I'm now a gem owner and an org owner. 🙏 🙏

nekketsuuu commented 1 year ago

@aamine Oh, I found commit https://github.com/bricolages/bricolage/commit/21dd0241f2509e2ac5caaacc86f641463f2aae9d, which is tagged as 6.0.0beta7, has not been pushed to master branch yet. Would you please push the commit?

aamine commented 1 year ago

Ah sorry, I have wrongly pushed only tags... Now pushed master.

nekketsuuu commented 1 year ago

Thanks!