search

bricoleurs / bricolage

Content management and publishing system
http://www.bricolagecms.org
112 stars 51 forks source link

Fix for #252: RELATED_MEDIA_UPLOAD dialog messages #23

Closed nlegg closed 13 years ago

nlegg commented 13 years ago

Added status messages to media upload dialog. Also added a 'blank' default media type selection.

theory commented 13 years ago

Can you tell me how to trigger this code? I can't find where the message should be displayed once your patch is applied.

Thanks,

Theory

nlegg commented 13 years ago

Sure. First, load the "Select Related Media" dialog (actually just a pop-up window) by clicking the "Edit" button on a media relation. As long as RELATED_MEDIA_UPLOAD is enabled in your config, this dialog window has the "Or upload as" drop-down menu, a "Choose File" file chooser button, and the "Create" button. My patch just added an 'empty' entry in the drop-down menu so you have to consciously select something. If you click "Create" without selecting a media type and/or without using the file chooser to select a file, the "Select Related Media" dialog window reloads with the corresponding status message at the top.

Hope that helps.

-Nick

theory commented 13 years ago

On Apr 19, 2011, at 6:25 AM, nlegg wrote:

Sure. First, load the "Select Related Media" dialog (actually just a pop-up window) by clicking the "Edit" button on a media relation. As long as RELATED_MEDIA_UPLOAD is enabled in your config, this dialog window has the "Or upload as" drop-down menu, a "Choose File" file chooser button, and the "Create" button. My patch just added an 'empty' entry in the drop-down menu so you have to consciously select something. If you click "Create" without selecting a media type and/or without using the file chooser to select a file, the "Select Related Media" dialog window reloads with the corresponding status message at the top.

Ah, got it. Thanks. Will apply.

David

theory commented 13 years ago

Applied, thanks!