search

bricoleurs / bricolage

Content management and publishing system
http://www.bricolagecms.org/
111 stars 51 forks source link

Add Amazon S3 Mover #28

Closed dse closed 12 years ago

dse commented 13 years ago

Greetings!

John Durkin john@j2d3.com has developed an Amazon S3 mover and told me that it works for him. Because he's too pressed for time himself, I'm stepping in to submit the code for inclusion in Bricolage. You'll find the changes (four modified files and one new one) in the "dev_amazon_s3" branch in my fork.

If you have any further questions please talk to both him and me.

Thanks!

theory commented 12 years ago

I added a few notes, as you can see, but I'd also like to see some tests. See t/Bric/Util/Trans/Mail/Test.pm and t/Bric/Util/Trans/Mail/DevTest.pm for how the Mail mover is tested depending on what's installed and such.

Thanks!

dse commented 12 years ago

Okay, this should be good. The test created in 2af2a5d is not really a stub (I misspoke in the commit msg) but it only checks for the prerequisite module, similar to the one for the SFTP mover.

theory commented 12 years ago

Loving the ability to comment on stuff here. Anyway, if you make the changes suggested in my comments, I'll pull. :-)

phillipadsmith commented 12 years ago

Hey there dse & theory: What's the status of this pull request?

theory commented 12 years ago

Merge it!