search

bricoleurs / bricolage

Content management and publishing system
http://www.bricolagecms.org/
111 stars 51 forks source link

Change /usr/bin/perl to /usr/bin/env perl ? #45

Closed phillipadsmith closed 10 years ago

phillipadsmith commented 10 years ago

Any reason not to change /usr/bin/perl to /usr/bin/env perl everywhere?

I find that I'm using perlbrew for managing my Perls these days, so I really want the Bricolage scripts and libraries to just use whatever Perl I have loaded into the environment, which is never at /usr/bin/perl.

Making that changed on bric_apachectl seemed to fix the issue I was having with getting a new install to start-up due to not finding other libraries in the PERL5LIB path.

Thoughts?

theory commented 10 years ago

Some older versions of Linux ship with an env where, when you specify

#!/usr/bin/env perl -w

Not only is the -w not passed to Perl, it results in an error, because it is not a valid option to env. So I never ship software using env.

The installer should replace the shebang line in scripts before it installs them. If it doesn't, it's a bug.

phillipadsmith commented 10 years ago

Here's what I'm seeing after an install with perlbrew perl:

Makefile.PL:#!/usr/bin/perl -w Makefile.in:PERL = /usr/bin/perl bin/bric_clean_tmp:#!/usr/bin/perl -w bin/bric_dbprof:#!/usr/bin/perl -w bin/bric_dev_sync:#!/usr/bin/perl -w bin/bric_dist_mon:#!/usr/bin/perl -w bin/bric_ftpd:#!/usr/bin/perl -w bin/bric_pgimport:#!/usr/bin/perl -w bin/bric_queued:#!/usr/bin/perl -w bin/bric_republish:#!/usr/bin/perl -w bin/bric_soap:#!/usr/bin/perl -w contrib/bric_events_rss/bric_events_rss:#!/usr/bin/perl -w contrib/bric_import_contribs/bin/bric_import_contribs:#!/usr/bin/perl -w contrib/bric_import_contribs/t/bric_import_contribs.t:#!/usr/bin/perl -w contrib/bric_init/bric_init.pl:#!/usr/bin/perl contrib/bric_mech_upload/bric_media_mech:#!/usr/bin/perl contrib/bric_mech_upload/bric_media_mech:eval 'exec /usr/bin/perl -w -S $0 ${1+"$@"}' contrib/bric_media_dump/bin/bric_media_dump:#!/usr/bin/perl -w contrib/bric_media_dump/t/bric_media_dump.t:#!/usr/bin/perl -w contrib/bric_media_load/bric_media_load:#!/usr/bin/perl -w contrib/bric_media_upload/bric_media_upload:#!/usr/bin/perl -w contrib/bric_media_upload/bric_media_upload:eval 'exec /usr/bin/perl -w -S $0 ${1+"$@"}' contrib/bric_template_diff/bric_template_diff:#!/usr/bin/perl -w contrib/bric_template_diff/bric_template_patch:#!/usr/bin/perl -w contrib/bric_template_dump/bin/bric_template_dump:#!/usr/bin/perl -w contrib/bric_template_dump/t/bric_template_dump.t:#!/usr/bin/perl -w contrib/bric_xfer/bric_xfer_grps:#!/usr/bin/perl contrib/bric_xfer/bric_xfer_grps:eval 'exec /usr/bin/perl -w -S $0 ${1+"$@"}' contrib/bric_xfer/bric_xfer_users:#!/usr/bin/perl contrib/bric_xfer/bric_xfer_users:eval 'exec /usr/bin/perl -w -S $0 ${1+"$@"}' contrib/BricMech/t/UI/000-testbase.t:#!/usr/bin/perl contrib/BricMech/t/UI/010-login.t:#!/usr/bin/perl contrib/BricMech/t/UI/020-leftnav.t:#!/usr/bin/perl contrib/BricMech/t/UI/030-help.t:#!/usr/bin/perl contrib/BricMech/t/UI/100-preferences.t:#!/usr/bin/perl contrib/BricMech/t/UI/110-users.t:#!/usr/bin/perl contrib/BricMech/t/UI/120-groups.t:#!/usr/bin/perl contrib/BricMech/t/UI/130-sites.t:#!/usr/bin/perl contrib/BricMech/t/UI/140-alerttypes.t:#!/usr/bin/perl contrib/BricMech/t/UI/200-outputchannels.t:#!/usr/bin/perl contrib/BricMech/t/UI/210-contributors.t:#!/usr/bin/perl contrib/BricMech/t/UI/220-contribtypes.t:#!/usr/bin/perl contrib/BricMech/t/UI/230-workflows.t:#!/usr/bin/perl contrib/BricMech/t/UI/240-categories.t:#!/usr/bin/perl contrib/BricMech/t/UI/250-elements.t:#!/usr/bin/perl contrib/BricMech/t/UI/260-elementtypes.t:#!/usr/bin/perl contrib/BricMech/t/UI/270-mediatypes.t:#!/usr/bin/perl contrib/BricMech/t/UI/280-sources.t:#!/usr/bin/perl contrib/BricMech/t/UI/290-keywords.t:#!/usr/bin/perl contrib/BricMech/t/UI/400-destination.t:#!/usr/bin/perl contrib/BricMech/t/UI/500-media.t:#!/usr/bin/perl contrib/BricMech/t/UI/600-story.t:#!/usr/bin/perl contrib/BricMech/t/UI/700-template.t:#!/usr/bin/perl contrib/BricMech/t/UI/800-workspace.t:#!/usr/bin/perl contrib/button_gen/bricolage_buttons.pl:#!/usr/bin/perl contrib/button_gen/bricolage_workflow_buttons.pl:#!/usr/bin/perl contrib/button_gen/bricolage_workspace_buttons.pl:#!/usr/bin/perl contrib/copy_gnome_icons/copy_gnome_icons:#!/usr/bin/perl -w contrib/republish_by_uri/bin/republish_by_uri:#!/usr/bin/perl -w contrib/republish_by_uri/t/republish_by_uri.t:#!/usr/bin/perl -w contrib/show_element_tree/element_tree.pl:#!/usr/bin/perl contrib/thumbnails/precreate-thumbs.pl:#!/usr/bin/perl inst/check_dist.pl:#!/usr/bin/perl -w inst/clone.pl:#!/usr/bin/perl -w inst/clone_files.pl:#!/usr/bin/perl -w inst/clone_lightweight.pl:#!/usr/bin/perl -w inst/clone_sql.pl:#!/usr/bin/perl -w inst/clone_sql_mysql.pl:#!/usr/bin/perl -w inst/clone_sql_Pg.pl:#!/usr/bin/perl -w inst/clone_tar.pl:#!/usr/bin/perl -w inst/conf.pl:#!/usr/bin/perl -w inst/config.pl:#!/usr/bin/perl -w inst/cpan.pl:#!/usr/bin/perl -w inst/database.pl:#!/usr/bin/perl -w inst/db.pl:#!/usr/bin/perl -w inst/db_uninst_mysql.pl:#!/usr/bin/perl -w inst/db_uninst_Pg.pl:#!/usr/bin/perl -w inst/db_uninstall.pl:#!/usr/bin/perl -w inst/db_upgrade.pl:#!/usr/bin/perl -w inst/dbgrant.pl:#!/usr/bin/perl -w inst/dbgrant_mysql.pl:#!/usr/bin/perl -w inst/dbgrant_Pg.pl:#!/usr/bin/perl -w inst/dbload_mysql.pl:#!/usr/bin/perl -w inst/dbload_Pg.pl:#!/usr/bin/perl -w inst/dbprobe_mysql.pl:#!/usr/bin/perl -w inst/dbprobe_Pg.pl:#!/usr/bin/perl -w inst/dev.pl:#!/usr/bin/perl -w inst/done.pl:#!/usr/bin/perl -w inst/files.pl:#!/usr/bin/perl -w inst/htprobe_apache.pl:#!/usr/bin/perl -w inst/htprobe_apache2.pl:#!/usr/bin/perl -w inst/httpd.pl:#!/usr/bin/perl -w inst/is_root.pl:#!/usr/bin/perl -w inst/lib/Bric/Inst.pm: #!/usr/bin/perl -w inst/modules.pl:#!/usr/bin/perl -w inst/required.pl:#!/usr/bin/perl -w inst/rm_files.pl:#!/usr/bin/perl -w inst/runtests.pl:#!/usr/bin/perl -w inst/stop.pl:#!/usr/bin/perl -w inst/uninstall.pl:#!/usr/bin/perl -w inst/upgrade/1.10.0/delete_old_stuff.pl:#!/usr/bin/perl -w inst/upgrade/1.10.0/rm_old_sort_prefs.pl:#!/usr/bin/perl -w inst/upgrade/1.10.0/update_publish_status_check.pl:#!/usr/bin/perl -w inst/upgrade/1.10.1/fix_media_related_story_fk.pl:#!/usr/bin/perl -w inst/upgrade/1.10.1/fix_reverted_docs.pl:#!/usr/bin/perl -w inst/upgrade/1.10.1/textify_field_type.pl:#!/usr/bin/perl -w inst/upgrade/1.10.2/add_asset_counts.pl:#!/usr/bin/perl -w inst/upgrade/1.10.2/add_ja.pl:#!/usr/bin/perl -w inst/upgrade/1.10.2/deleted_moved_js.pl:#!/usr/bin/perl -w inst/upgrade/1.10.2/fix_reverted_docs.pl:#!/usr/bin/perl -w inst/upgrade/1.10.3/alter_category_name_length.pl:#!/usr/bin/perl -w inst/upgrade/1.10.3/fix_asset_fk_constraints.pl:#!/usr/bin/perl -w inst/upgrade/1.10.3/fix_asset_sort_opts.pl:#!/usr/bin/perl -w inst/upgrade/1.10.3/fix_contri_assoc.pl:#!/usr/bin/perl -w inst/upgrade/1.10.3/fix_story_elementtype_spelling.pl:#!/usr/bin/perl -w inst/upgrade/1.10.6/update_doc_version_indexes.pl:#!/usr/bin/perl -w inst/upgrade/1.10.7/event_timestamp.pl:#!/usr/bin/perl -w inst/upgrade/1.11.0/add_element_type_occurrence.pl:#!/usr/bin/perl -w inst/upgrade/1.11.0/add_field_type_occurrence.pl:#!/usr/bin/perl -w inst/upgrade/1.11.0/change_aggregate_name_Pg.pl:#!/usr/bin/perl -w inst/upgrade/1.11.0/delete_old_stuff.pl:#!/usr/bin/perl -w inst/upgrade/1.11.1/add_displayed.pl:#!/usr/bin/perl -w inst/upgrade/1.11.2/cover_date_not_null.pl:#!/usr/bin/perl -w inst/upgrade/1.2.0/burner.pl:#!/usr/bin/perl -w inst/upgrade/1.2.0/oc_include.pl:#!/usr/bin/perl -w inst/upgrade/1.2.0/oc_include_fks.pl:#!/usr/bin/perl -w inst/upgrade/1.2.2/media_member_tables.pl:#!/usr/bin/perl -w inst/upgrade/1.2.2/media_member_tables_fks.pl:#!/usr/bin/perl -w inst/upgrade/1.3.0/element_names.pl:#!/usr/bin/perl -w inst/upgrade/1.3.1/mover.pl:#!/usr/bin/perl -w inst/upgrade/1.3.1/template_uri_fix.pl:#!/usr/bin/perl -w inst/upgrade/1.3.1/uri_case.pl:#!/usr/bin/perl -w inst/upgrade/1.3.1/uri_format.pl:#!/usr/bin/perl -w inst/upgrade/1.3.2/job_names.pl:#!/usr/bin/perl -w inst/upgrade/1.3.2/published_version.pl:#!/usr/bin/perl -w inst/upgrade/1.3.2/search_paging.pl:#!/usr/bin/perl -w inst/upgrade/1.3.3/category.pl:#!/usr/bin/perl -w inst/upgrade/1.3.3/elem_data.pl:#!/usr/bin/perl -w inst/upgrade/1.3.3/grp_ex_category.pl:#!/usr/bin/perl -w inst/upgrade/1.3.3/grp_new_category.pl:#!/usr/bin/perl -w inst/upgrade/1.3.3/grp_parent_chk.pl:#!/usr/bin/perl -w inst/upgrade/1.3.3/keywords.pl:#!/usr/bin/perl -w inst/upgrade/1.3.3/mediatype_admin.pl:#!/usr/bin/perl -w inst/upgrade/1.3.3/sftp_mover.pl:#!/usr/bin/perl -w inst/upgrade/1.3.3/tile_dates.pl:#!/usr/bin/perl -w inst/upgrade/1.4.1/bric_class.pl:#!/usr/bin/perl -w inst/upgrade/1.4.1/bric_shelve.pl:#!/usr/bin/perl -w inst/upgrade/1.4.1/cat_asset_grp_desc.pl:#!/usr/bin/perl -w inst/upgrade/1.4.1/clean_desks.pl:#!/usr/bin/perl -w inst/upgrade/1.4.1/fix_tmpl_check.pl:#!/usr/bin/perl -w inst/upgrade/1.4.1/resource_indexes.pl:#!/usr/bin/perl -w inst/upgrade/1.4.4/short_val.pl:#!/usr/bin/perl -w inst/upgrade/1.4.5/aroot_cat_memb.pl:#!/usr/bin/perl -w inst/upgrade/1.4.5/cat_grp_uris.pl:#!/usr/bin/perl -w inst/upgrade/1.5.0/asset_oc.pl:#!/usr/bin/perl -w inst/upgrade/1.5.0/asset_oc_fks.pl:#!/usr/bin/perl -w inst/upgrade/1.5.0/bric_instance.pl:#!/usr/bin/perl -w inst/upgrade/1.5.0/clone_events.pl:#!/usr/bin/perl -w inst/upgrade/1.5.0/kw_events.pl:#!/usr/bin/perl -w inst/upgrade/1.5.0/oc_assoc_events.pl:#!/usr/bin/perl -w inst/upgrade/1.5.0/oc_select.pl:#!/usr/bin/perl -w inst/upgrade/1.5.0/oc_uri_stuff.pl:#!/usr/bin/perl -w inst/upgrade/1.5.0/oc_zasset.pl:#!/usr/bin/perl -w inst/upgrade/1.5.0/template_type.pl:#!/usr/bin/perl -w inst/upgrade/1.5.1/activate_all_grp_members.pl:#!/usr/bin/perl -w inst/upgrade/1.5.1/add_lower_text_num.pl:#!/usr/bin/perl -w inst/upgrade/1.5.1/all_desk_grp.pl:#!/usr/bin/perl -w inst/upgrade/1.5.1/asset_desk.pl:#!/usr/bin/perl -w inst/upgrade/1.5.1/cat_grp_plural.pl:#!/usr/bin/perl -w inst/upgrade/1.5.1/grp_grp_members.pl:#!/usr/bin/perl -w inst/upgrade/1.5.1/media_type_grp.pl:#!/usr/bin/perl -w inst/upgrade/1.5.1/media_type_grp_idxs.pl:#!/usr/bin/perl -w inst/upgrade/1.5.1/media_type_idx.pl:#!/usr/bin/perl -w inst/upgrade/1.5.1/person_idx.pl:#!/usr/bin/perl -w inst/upgrade/1.5.1/root_cat_grp_uri.pl:#!/usr/bin/perl -w inst/upgrade/1.5.1/tmplate_pub_version.pl:#!/usr/bin/perl -w inst/upgrade/1.5.1/webdav_mover.pl:#!/usr/bin/perl -w inst/upgrade/1.5.2/media_type_constraints.pl:#!/usr/bin/perl -w inst/upgrade/1.5.2/workflow_grps.pl:#!/usr/bin/perl -w inst/upgrade/1.5.2/workflow_no_create.pl:#!/usr/bin/perl -w inst/upgrade/1.6.0/element_data.pl:#!/usr/bin/perl -w inst/upgrade/1.6.0/fix_workflow_asset_grps.pl:#!/usr/bin/perl -w inst/upgrade/1.6.1/del_media_subclass_member_tables.pl:#!/usr/bin/perl -w inst/upgrade/1.6.10/fix_asset_desk_constraints.pl:#!/usr/bin/perl -w inst/upgrade/1.6.10/fix_asset_indexes.pl:#!/usr/bin/perl -w inst/upgrade/1.6.3/fix_contributor_class_desc.pl:#!/usr/bin/perl -w inst/upgrade/1.6.3/rename_field_events.pl:#!/usr/bin/perl -w inst/upgrade/1.6.3/tmplate_file_name.pl:#!/usr/bin/perl -w inst/upgrade/1.6.5/event_index.pl:#!/usr/bin/perl -w inst/upgrade/1.6.6/asset_desk_ids.pl:#!/usr/bin/perl -w inst/upgrade/1.6.7/fix_grp_element_index.pl:#!/usr/bin/perl -w inst/upgrade/1.6.7/job_partial_index.pl:#!/usr/bin/perl -w inst/upgrade/1.6.9/del_bogus_event_attrs.pl:#!/usr/bin/perl -w inst/upgrade/1.7.0/action_active.pl:#!/usr/bin/perl -w inst/upgrade/1.7.0/add_site.pl:#!/usr/bin/perl -w inst/upgrade/1.7.0/add_site_idxs.pl:#!/usr/bin/perl -w inst/upgrade/1.7.0/alias_events.pl:#!/usr/bin/perl -w inst/upgrade/1.7.0/asset_type_data_key_name.pl:#!/usr/bin/perl -w inst/upgrade/1.7.0/asset_type_key_name.pl:#!/usr/bin/perl -w inst/upgrade/1.7.0/checkin_event_version.pl:#!/usr/bin/perl -w inst/upgrade/1.7.0/container_tile_key_name.pl:#!/usr/bin/perl -w inst/upgrade/1.7.0/data_tile_key_name.pl:#!/usr/bin/perl -w inst/upgrade/1.7.0/delete_old_components.pl:#!/usr/bin/perl -w inst/upgrade/1.7.0/dtd_validation_action.pl:#!/usr/bin/perl -w inst/upgrade/1.7.0/email_action.pl:#!/usr/bin/perl -w inst/upgrade/1.7.0/keyword_grp.pl:#!/usr/bin/perl -w inst/upgrade/1.7.0/keyword_grp_fks.pl:#!/usr/bin/perl -w inst/upgrade/1.7.0/keyword_idx.pl:#!/usr/bin/perl -w inst/upgrade/1.7.0/search_pref.pl:#!/usr/bin/perl -w inst/upgrade/1.7.0/site_asset.pl:#!/usr/bin/perl -w inst/upgrade/1.7.0/site_category.pl:#!/usr/bin/perl -w inst/upgrade/1.7.0/site_elements.pl:#!/usr/bin/perl -w inst/upgrade/1.7.0/site_elements_fks.pl:#!/usr/bin/perl -w inst/upgrade/1.7.0/site_events.pl:#!/usr/bin/perl -w inst/upgrade/1.7.0/site_output_channel.pl:#!/usr/bin/perl -w inst/upgrade/1.7.0/site_privs.pl:#!/usr/bin/perl -w inst/upgrade/1.7.0/site_server_type.pl:#!/usr/bin/perl -w inst/upgrade/1.7.0/sort_asset.pl:#!/usr/bin/perl -w inst/upgrade/1.7.0/workflow_site.pl:#!/usr/bin/perl -w inst/upgrade/1.7.1/element_site_oc_not_null.pl:#!/usr/bin/perl -w inst/upgrade/1.7.2/delete_invalid_site_member.pl:#!/usr/bin/perl -w inst/upgrade/1.7.2/element_key_name_fix.pl:#!/usr/bin/perl -w inst/upgrade/1.7.2/first_publish_date.pl:#!/usr/bin/perl -w inst/upgrade/1.7.2/fix_at_data_index.pl:#!/usr/bin/perl -w inst/upgrade/1.7.2/group_site_permissions.pl:#!/usr/bin/perl -w inst/upgrade/1.7.2/hidden_asset_group.pl:#!/usr/bin/perl -w inst/upgrade/1.7.2/new_priv_site_grps.pl:#!/usr/bin/perl -w inst/upgrade/1.7.2/new_privs.pl:#!/usr/bin/perl -w inst/upgrade/1.7.2/publish_jobs.pl:#!/usr/bin/perl -w inst/upgrade/1.7.2/rm_dhandlers.pl:#!/usr/bin/perl -w inst/upgrade/1.7.2/site_filter_pref.pl:#!/usr/bin/perl -w inst/upgrade/1.7.2/user_preferences_1.pl:#!/usr/bin/perl -w inst/upgrade/1.7.2/user_preferences_2.pl:#!/usr/bin/perl -w inst/upgrade/1.7.2/user_preferences_3.pl:#!/usr/bin/perl -w inst/upgrade/1.7.2/user_preferences_4.pl:#!/usr/bin/perl -w inst/upgrade/1.7.3/deactivate_inative_cat_grps.pl:#!/usr/bin/perl -w inst/upgrade/1.7.3/fix_autopopulated_data_key_name.pl:#!/usr/bin/perl -w inst/upgrade/1.7.3/fix_autopopulated_data_tile_key_name.pl:#!/usr/bin/perl -w inst/upgrade/1.7.3/id_list_aggregate.pl:#!/usr/bin/perl -w inst/upgrade/1.7.3/unique_uri_tables.pl:#!/usr/bin/perl -w inst/upgrade/1.7.4/add_category_group_site.pl:#!/usr/bin/perl -w inst/upgrade/1.7.4/new_asset_indexes.pl:#!/usr/bin/perl -w inst/upgrade/1.7.4/new_login_constraint.pl:#!/usr/bin/perl -w inst/upgrade/1.7.5/default_template_events.pl:#!/usr/bin/perl -w inst/upgrade/1.7.5/fix_media_aliases.pl:#!/usr/bin/perl -w inst/upgrade/1.8.0/new_lang_pref_options.pl:#!/usr/bin/perl -w inst/upgrade/1.8.1/contrib_type_secret.pl:#!/usr/bin/perl -w inst/upgrade/1.8.1/fix_orphan_assets.pl:#!/usr/bin/perl -w inst/upgrade/1.8.1/grp_grp_name.pl:#!/usr/bin/perl -w inst/upgrade/1.8.2/add_missing_job_constraints.pl:#!/usr/bin/perl -w inst/upgrade/1.8.2/add_missing_job_fks.pl:#!/usr/bin/perl -w inst/upgrade/1.8.2/default_media_type.pl:#!/usr/bin/perl -w inst/upgrade/1.8.2/delete_old_jobs.pl:#!/usr/bin/perl -w inst/upgrade/1.8.2/delete_template_obj_files.pl:#!/usr/bin/perl -w inst/upgrade/1.8.2/job_text_columns.pl:#!/usr/bin/perl -w inst/upgrade/1.8.2/media_type_not_null.pl:#!/usr/bin/perl -w inst/upgrade/1.8.3/add_ru_ru.pl:#!/usr/bin/perl -w inst/upgrade/1.8.3/asset_fks_restrict.pl:#!/usr/bin/perl -w inst/upgrade/1.8.3/cleanup_job_members.pl:#!/usr/bin/perl -w inst/upgrade/1.8.3/element__site_pk.pl:#!/usr/bin/perl -w inst/upgrade/1.8.3/event_attr_pk.pl:#!/usr/bin/perl -w inst/upgrade/1.8.3/fix_all_preferences_group_spelling.pl:#!/usr/bin/perl -w inst/upgrade/1.8.3/fix_event_sequence.pl:#!/usr/bin/perl -w inst/upgrade/1.8.3/media_uri_pk.pl:#!/usr/bin/perl -w inst/upgrade/1.8.3/story_uri_pk.pl:#!/usr/bin/perl -w inst/upgrade/1.8.3/worfkow_type_ck.pl:#!/usr/bin/perl -w inst/upgrade/1.8.4/replace_action_media_types.pl:#!/usr/bin/perl -w inst/upgrade/1.8.6/fix_autopopulateds.pl:#!/usr/bin/perl -w inst/upgrade/1.8.6/fix_published_version.pl:#!/usr/bin/perl -w inst/upgrade/1.8.6/fix_resource_idx.pl:#!/usr/bin/perl -w inst/upgrade/1.8.6/fix_story_category_seq.pl:#!/usr/bin/perl -w inst/upgrade/1.8.7/add_expire_event_types.pl:#!/usr/bin/perl -w inst/upgrade/1.8.7/fix_media.pl:#!/usr/bin/perl -w inst/upgrade/1.8.7/fix_media2.pl:#!/usr/bin/perl -w inst/upgrade/1.8.7/job_partial_index.pl:#!/usr/bin/perl -w inst/upgrade/1.8.7/move_media.pl:#!/usr/bin/perl -w inst/upgrade/1.8.7/move_media2.pl:#!/usr/bin/perl -w inst/upgrade/1.8.7/postgresql_8.1_fixes.pl:#!/usr/bin/perl -w inst/upgrade/1.8.8/fix_media_expire.pl:#!/usr/bin/perl -w inst/upgrade/1.8.8/fix_media_resources.pl:#!/usr/bin/perl -w inst/upgrade/1.8.9/add_element_member_fks.pl:#!/usr/bin/perl -w inst/upgrade/1.8.9/add_keyword_fks.pl:#!/usr/bin/perl -w inst/upgrade/1.8.9/add_media_contributor_fks.pl:#!/usr/bin/perl -w inst/upgrade/1.8.9/fix_publish_status.pl:#!/usr/bin/perl -w inst/upgrade/1.8.9/rename_keyword_pks.pl:#!/usr/bin/perl -w inst/upgrade/1.8.9/update_publish_status_check.pl:#!/usr/bin/perl -w inst/upgrade/1.9.0/add_alpha_search_pref.pl:#!/usr/bin/perl -w inst/upgrade/1.9.0/add_media_del_file.pl:#!/usr/bin/perl -w inst/upgrade/1.9.0/add_uuid1.pl:#!/usr/bin/perl -w inst/upgrade/1.9.0/add_uuid2.pl:#!/usr/bin/perl -w inst/upgrade/1.9.0/delete_old_desk_component.pl:#!/usr/bin/perl -w inst/upgrade/1.9.0/flexible_uri_formats.pl:#!/usr/bin/perl -w inst/upgrade/1.9.0/log_user_override.pl:#!/usr/bin/perl -w inst/upgrade/1.9.0/new_strftime_prefs.pl:#!/usr/bin/perl -w inst/upgrade/1.9.0/no_more_numeric.pl:#!/usr/bin/perl -w inst/upgrade/1.9.0/source_privs.pl:#!/usr/bin/perl -w inst/upgrade/1.9.1/add_job_reset_event.pl:#!/usr/bin/perl -w inst/upgrade/1.9.1/add_subelement_type_events.pl:#!/usr/bin/perl -w inst/upgrade/1.9.1/add_uri_slash.pl:#!/usr/bin/perl -w inst/upgrade/1.9.1/add_windows_encodings.pl:#!/usr/bin/perl -w inst/upgrade/1.9.1/delete_old_stuff.pl:#!/usr/bin/perl -w inst/upgrade/1.9.1/delete_super_bulk_edit.pl:#!/usr/bin/perl -w inst/upgrade/1.9.1/move_notes.pl:#!/usr/bin/perl -w inst/upgrade/1.9.1/normalize_elements.pl:#!/usr/bin/perl -w inst/upgrade/1.9.1/normalize_et_data.pl:#!/usr/bin/perl -w inst/upgrade/1.9.1/rename_element_grps.pl:#!/usr/bin/perl -w inst/upgrade/1.9.1/rename_element_table.pl:#!/usr/bin/perl -w inst/upgrade/1.9.1/rename_element_type.pl:#!/usr/bin/perl -w inst/upgrade/1.9.1/rename_field_table.pl:#!/usr/bin/perl -w inst/upgrade/1.9.1/rename_field_type.pl:#!/usr/bin/perl -w inst/upgrade/1.9.1/rename_indexes.pl:#!/usr/bin/perl -w inst/upgrade/1.9.1/rename_instance_column.pl:#!/usr/bin/perl -w inst/upgrade/1.9.1/rename_tile_tables.pl:#!/usr/bin/perl -w inst/upgrade/1.9.1/update_element_classes.pl:#!/usr/bin/perl -w inst/upgrade/1.9.1/xtract_attype.pl:#!/usr/bin/perl -w inst/upgrade/1.9.1/xtract_attype2.pl:#!/usr/bin/perl -w inst/upgrade/1.9.1/xtricate_map_type_id.pl:#!/usr/bin/perl -w inst/upgrade/1.9.1/zap_doc_dates.pl:#!/usr/bin/perl -w inst/upgrade/1.9.1/zap_et_burner.pl:#!/usr/bin/perl -w inst/upgrade/1.9.1/zap_formatting.pl:#!/usr/bin/perl -w inst/upgrade/1.9.1/zap_oc_prefix_suffix.pl:#!/usr/bin/perl -w inst/upgrade/1.9.1/ze_job_iz_versioned.pl:#!/usr/bin/perl -w inst/upgrade/2.1.0/add_bulk_edit_pref.pl:#!/usr/bin/perl -w inst/upgrade/2.1.0/add_desk_triggers.pl:#!/usr/bin/perl -w inst/upgrade/2.1.0/s3_mover.pl:#!/usr/bin/perl -w inst/upgrade/2.1.0/version_columns.pl:#!/usr/bin/perl -w inst/upgrade/lib/bric_upgrade.pm: #!/usr/bin/perl -w inst/upgrade.pl:#!/usr/bin/perl -w lib/Bric/Admin.pod:This Configure command will arrange for /usr/bin/perl to be linked to the lib/Bric/Admin.pod:prompt you to find out whether to link /usr/bin/perl to the current version of lib/Bric/Changes.pod:commands in output. Also now uses /usr/bin/perl instead of /usr/local/bin/perl lib/Bric/Util/Time.pm: #!/usr/bin/perl -w sql/mysql/Bric/Biz/ElementType.con:#!/usr/bin/perl -w sql/mysql/Bric/Util/Pref.val:#!/usr/bin/perl -w sql/Pg/Bric/Biz/ElementType.con:#!/usr/bin/perl -w sql/Pg/Bric/Util/Pref.val:#!/usr/bin/perl -w t/Bric/App/Authz/Test.pm:#!/usr/bin/perl -w t/Bric/App/Event/Test.pm:#!/usr/bin/perl -w t/Bric/Biz/Asset/Template/Test.pm:#!/usr/bin/perl t/Bric/Biz/Org/Parts/Addr/Test.pm:#!/usr/bin/perl -w t/Bric/Biz/Org/Person/DevTest.pm:#!/usr/bin/perl -w t/Bric/Biz/Workflow/Parts/Desk/Test.pm:#!/usr/bin/perl -w t/Bric/Dist/ActionType/Test.pm:#!/usr/bin/perl -w t/Bric/Dist/Resource/Test.pm:#!/usr/bin/perl -w t/Bric/SOAP/Category/Test.pm:#!/usr/bin/perl -w t/Bric/SOAP/Media/Test.pm:#!/usr/bin/perl -w t/Bric/SOAP/Story/Test.pm:#!/usr/bin/perl -w t/Bric/SOAP/Template/Test.pm:#!/usr/bin/perl -w t/Bric/SOAP/Workflow/Test.pm:#!/usr/bin/perl -w t/Bric/Util/Attribute/Test.pm:#!/usr/bin/perl56 -w t/Bric/Util/Class/Test.pm:#!/usr/bin/perl -w t/Bric/Util/Event/Test.pm:#!/usr/bin/perl -w t/Bric/Util/EventType/Test.pm:#!/usr/bin/perl -w t/Bric/Util/Grp/Parts/Member/Contrib/Test.pm:#!/usr/bin/perl -w t/Bric/Util/Grp/Parts/Member/Test.pm:#!/usr/bin/perl -w t/Bric/Util/Grp/User/Test.pm:#!/usr/bin/perl -w t/Bric/Util/Pref/Test.pm:#!/usr/bin/perl -w t/Bric/Util/Priv/Test.pm:#!/usr/bin/perl -w

theory commented 10 years ago

Did you first run perl Makefile.PL? That will set PERL to the proper Perl.

theory commented 10 years ago

Also, don't forget make dev.

phillipadsmith commented 10 years ago

@theory I ran 'perl Makefile.PL' indeed, but I didn't realize that I needed to tell it what Perl to use. It seemed to pick-up on what Perl was loaded into the environment for everything else.

Wondering out loud: would /usr/local/bin/perl make more sense these days as a default?

P.S. Yep, I did a 'make dev' too. :)

theory commented 10 years ago

Makefile.PL should update the Makefile with the perl with which you executed it.

No, /usr/local/bin/perl does not make more sense; /usr/bin/perl is far and away the most common. And I say that as someone who has used and preferred /usr/local/bin/perl for at least 13 years. This is one of the reasons for make dev: it should let you use whatever Perl you like.

phillipadsmith commented 10 years ago

@theory Hmmm... I don't think that running 'perl Makefile.PL' updates bric_apachectl and so on (or the other files listed above), as I did run it with this perl:

➜ ~ perl -v This is perl 5, version 16, subversion 3 (v5.16.3) built for darwin-2level

➜ ~ which perl /Users/phillipadsmith/perl5/perlbrew/perls/perl-5.16.3/bin/perl

theory commented 10 years ago 
> make bin
rm -f bin/Makefile
cd bin; /usr/local/bin/perl Makefile.PL; make install
Writing Makefile for bric_bin
Writing MYMETA.yml and MYMETA.json
cp ./bric_dbprof blib/script/bric_dbprof
/usr/local/bin/perl -MExtUtils::MY -e 'MY->fixin(shift)' -- blib/script/bric_dbprof
cp ./bric_queued blib/script/bric_queued
/usr/local/bin/perl -MExtUtils::MY -e 'MY->fixin(shift)' -- blib/script/bric_queued
cp ./bric_soap blib/script/bric_soap
/usr/local/bin/perl -MExtUtils::MY -e 'MY->fixin(shift)' -- blib/script/bric_soap
cp ./bric_republish blib/script/bric_republish
/usr/local/bin/perl -MExtUtils::MY -e 'MY->fixin(shift)' -- blib/script/bric_republish
cp ./bric_dev_sync blib/script/bric_dev_sync
/usr/local/bin/perl -MExtUtils::MY -e 'MY->fixin(shift)' -- blib/script/bric_dev_sync
cp ./bric_clean_tmp blib/script/bric_clean_tmp
/usr/local/bin/perl -MExtUtils::MY -e 'MY->fixin(shift)' -- blib/script/bric_clean_tmp
cp ./bric_dist_mon blib/script/bric_dist_mon
/usr/local/bin/perl -MExtUtils::MY -e 'MY->fixin(shift)' -- blib/script/bric_dist_mon
cp ./bric_ftpd blib/script/bric_ftpd
/usr/local/bin/perl -MExtUtils::MY -e 'MY->fixin(shift)' -- blib/script/bric_ftpd
cp ./bric_apachectl blib/script/bric_apachectl
/usr/local/bin/perl -MExtUtils::MY -e 'MY->fixin(shift)' -- blib/script/bric_apachectl
cp ./bric_pgimport blib/script/bric_pgimport
/usr/local/bin/perl -MExtUtils::MY -e 'MY->fixin(shift)' -- blib/script/bric_pgimport
Manifying blib/man1/bric_apachectl.1
Manifying blib/man1/bric_pgimport.1
Manifying blib/man1/bric_ftpd.1
Manifying blib/man1/bric_dist_mon.1
Manifying blib/man1/bric_clean_tmp.1
Manifying blib/man1/bric_dev_sync.1
Manifying blib/man1/bric_republish.1
Manifying blib/man1/bric_soap.1
Manifying blib/man1/bric_queued.1
Manifying blib/man1/bric_dbprof.1
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
ERROR: Can't create '/usr/local/bin'
Do not have write permissions on '/usr/local/bin'
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
 at -e line 1.
make[1]: *** [pure_site_install] Error 13
make: *** [bin] Error 2

> head -1 bin/blib/script/bric_apachectl
#!/usr/local/bin/perl -w

That is as it should be. However, IIRC, make dev will symlink $BRIC_ROOT/bin to bin, not bin/blib/bin, so you would not get that. When I do dev work, I work around that by running, say, perl bin/bric_apachectl.

But if you do make install, $BRIC_ROOT/bin will have the properly updated scripts.

phillipadsmith commented 10 years ago

@theory Okay, I'll make a note and give that a try next time. :)