search

bricoleurs / bricolage

Content management and publishing system
http://www.bricolagecms.org
112 stars 51 forks source link

Fix related link edit pagination #49

Open brewt opened 10 years ago

brewt commented 10 years ago

$id arg wasn't being preserved on pagination causing a fatal error. Modified the template to just do the same thing that edit_related_media.html does.

theory commented 10 years ago

I've made you a committer, @brewt, so you can merge these commits yourself. Since they're bug fixes, please merge them into both master and rel-2.0.

BTW, are you running the full devtest test suite?

brewt commented 10 years ago

Not yet unfortunately. I've been working on a client dev install and haven't had a chance to set up a local instance to run the tests on.

phillipadsmith commented 10 years ago

➜ bricolage-2.1.0 git:(brewt-related_story_paging_fix) ✗ sudo make devtest PERL_DL_NONLAZY=1 /Users/phillipadsmith/perl5/perlbrew/perls/perl-5.16.1/bin/perl inst/runtests.pl -d t/Bric/Test/Runner.pm .. 1/? # expected 41 test(s) in Bric::Util::Pref::DevTest::test_list, 42 completed t/Bric/Test/Runner.pm .. 11691/? # expected 26 test(s) in Bric::Biz::Asset::Business::Media::Image::DevTest::test_alternate_thumb, 27 completed t/Bric/Test/Runner.pm .. ok All tests successful. Files=1, Tests=12710, 35 wallclock secs ( 1.90 usr 0.15 sys + 21.84 cusr 1.56 csys = 25.45 CPU) Result: PASS

theory commented 10 years ago

Merge it into master and rev-2.0, and note it in the rev-2.0 Changes.

theory commented 9 years ago

Update: Merge it into master and screw rev-2.0. We should just release 2.2.

phillipadsmith commented 9 years ago

Let me know when I can find you on IRC and I'll give this another go. I got half-way through and hit those failing tests. Now resolved.