bridgecrewio / checkov

Prevent cloud misconfigurations and find vulnerabilities during build-time in infrastructure as code, container images and open source packages with Checkov by Bridgecrew.
https://www.checkov.io/
Apache License 2.0
7.1k stars 1.12k forks source link

fix(general): Fix accidentally merged categories in prompt.py #6449

Open InputUsername opened 4 months ago

InputUsername commented 4 months ago

User description

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[//]: # "

PR Title

Be aware that we use the title to create changelog automatically and therefore only allow specific prefixes
- break:    to indicate a breaking change, this supersedes any of the types
- feat:     to indicate new features or checks
- fix:      to indicate a bugfix or handling of edge cases of existing checks
- docs:     to indicate an update to our documentation
- chore:    to indicate adjustments to workflow files or dependency updates
- platform: to indicate a change needed for the platform
Additionally a scope is needs to be added to the prefix, which indicates the targeted framework, in doubt choose 'general'.
#    
Allowed prefixs:
ansible|argo|arm|azure|bicep|bitbucket|circleci|cloudformation|dockerfile|github|gha|gitlab|helm|kubernetes|kustomize|openapi|sast|sca|secrets|serverless|terraform|general|graph|terraform_plan|terraform_json
#
ex.
feat(terraform): add CKV_AWS_123 to ensure that VPC Endpoint Service is configured for Manual Acceptance

"

Description

The missing comma caused backup_and_recovery and convention to be merged into one category preventing either category from being specified.

Checklist:


Generated description

Dear maintainer, below is a concise technical summary of the changes proposed in this PR:

Fix a missing comma in prompt.py that caused backup_and_recovery and convention categories to merge, preventing their individual specification.

<table><tr><th>Topic</th><th>Details</th><tr><td><a href=https://baz.co/changes/bridgecrewio/checkov/6449?tool=ast&topic=Category+Fix>Category Fix</a>
    </td><td>Correct a syntax error in the <code>CATEGORIES</code> list of <code>Prompt</code> class to ensure proper category separation.<details><summary>Modified files (1)</summary><ul><li>checkov/common/util/prompt.py</li></ul></details><details><summary>Latest Contributors(2)</summary><table><tr><th>Email</th><th>Commit</th><th>Date</th></tr><tr><td>anton.gruebel@gmail.com</td><td>Improve-type-hints-in-...</td><td>May 08, 2022</td></tr>
17982571+jmeredith16@u...Check-Generator-CLI-Pr...November 08, 2021This pull request is reviewed by Baz. Join @InputUsername and the rest of your team on (Baz).
itai1357 commented 3 months ago

Hi @InputUsername . can you please make sure your source branch is up-to-date with bridgecrewio:main?

InputUsername commented 3 months ago

@itai1357 is this OK or do you want me to rebase?