bridgecrewio / checkov

Prevent cloud misconfigurations and find vulnerabilities during build-time in infrastructure as code, container images and open source packages with Checkov by Bridgecrew.
https://www.checkov.io/
Apache License 2.0
7.16k stars 1.12k forks source link

fix(general): fixed mypy issue #6838

Closed bo156 closed 1 week ago

bo156 commented 1 week ago

User description

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[//]: # "

PR Title

We use the title to create changelog automatically and therefore only allow specific prefixes
- break:    to indicate a breaking change, this supersedes any of the other types
- feat:     to indicate new features or checks
- fix:      to indicate a bugfix or handling of edge cases of existing checks
- docs:     to indicate an update to our documentation
- chore:    to indicate adjustments to workflow files or dependency updates
- platform: to indicate a change needed for the platform
Each prefix should be accompanied by a scope that specifies the targeted framework. If uncertain, use 'general'.
#    
Allowed prefixs:
ansible|argo|arm|azure|bicep|bitbucket|circleci|cloudformation|dockerfile|github|gha|gitlab|helm|kubernetes|kustomize|openapi|sast|sca|secrets|serverless|terraform|general|graph|terraform_plan|terraform_json
#
ex.
feat(terraform): add CKV_AWS_123 to ensure that VPC Endpoint Service is configured for Manual Acceptance

"

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

New/Edited policies (Delete if not relevant)

Description

Include a description of what makes it a violation and any relevant external links.

Fix

How does someone fix the issue in code and/or in runtime?

Checklist:


Generated description

Below is a concise technical summary of the changes proposed in this PR:

Address a mypy type issue in the PrismaEngine class by adding type ignore comments and refining the logic for removing non-conforming incidents policies.

<table><tr><th>Topic</th><th>Details</th><tr><td><a href=https://baz.co/changes/bridgecrewio/checkov/6838?tool=ast&topic=Type+Checking>Type Checking</a>
    </td><td>Add type ignore comments to resolve mypy type checking issues in <code>PrismaEngine</code>.<details><summary>Modified files (1)</summary><ul><li>checkov/sast/engines/prisma_engine.py</li></ul></details><details><summary>Latest Contributors(2)</summary><table><tr><th>User</th><th>Commit</th><th>Date</th></tr><tr><td>matanshati@gmail.com</td><td>fix-sast-filter-unsupp...</td><td>November 12, 2024</td></tr>
@omryMenfeat-sast-add-log-leve...September 05, 2024 Policy Handling Refine the logic in remove_none_conf_incidents_policies to handle missing policyMetadata more gracefully.
Modified files (1)
  • checkov/sast/engines/prisma_engine.py
Latest Contributors(2)
UserCommitDate
matanshati@gmail.comfix-sast-filter-unsupp...November 12, 2024
@omryMenfeat-sast-add-log-leve...September 05, 2024
This pull request is reviewed by Baz. Join @bo156 and the rest of your team on (Baz).