search

bridgecrewio / terraform-aws-session-manager

Terraform module for deploying AWS Session Manager
Apache License 2.0
43 stars 46 forks source link

Add Shell Profiles and Fix Pre-Commit #17

Closed apanzerj closed 2 years ago

apanzerj commented 2 years ago

Add support for shell profiles into this module.

JamesWoolfenden commented 2 years ago

If you merge with the latest ill take a look at adding the profiles.

apanzerj commented 2 years ago

@JamesWoolfenden Done!

apanzerj commented 2 years ago

(I'll take a look at the other PR and see if I can add more of it too, I just need a bit to fix other stuff I'm working on)

apanzerj commented 2 years ago

@JamesWoolfenden I made a go at the other PR and doing a rebase but the code fails several checkov rules and I'm not actually going to use any of the features it builds on that this PR isn't already implementing. Any chance I can get a review when you have a minute?

JamesWoolfenden commented 2 years ago

LGTM not sure whats going on that other PR but this one seems fine

JamesWoolfenden commented 2 years ago

thanks for the contribution!

apanzerj commented 2 years ago

Woot thanks!