search

bridgecrewio / yor

Extensible auto-tagger for your IaC files. The ultimate way to link entities in the cloud back to the codified resource which created it.
https://www.yor.io
Apache License 2.0
827 stars 123 forks source link

Add depth check for brace and paren to fix #297 #298

Closed lonegunmanb closed 1 year ago

lonegunmanb commented 2 years ago

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

This patch added a depth check for brace and paren to fix incorrect tag value parse.

lonegunmanb commented 2 years ago

Unfortunately I found that the gosec issue and failed tests also exist in the main branch. I'll try to fix them in this pr but cannot guarantee it.

lonegunmanb commented 2 years ago

Sign off, I've passed all unit tests and integration tests on my machine, and I've fixed gosec issue, could we run CI for this pr please? Thanks.

lonegunmanb commented 2 years ago

Hi @nimrodkor , would you please give this pr a review? Thanks!

lonegunmanb commented 2 years ago

Hi, I've solved the conflicts, can anyone give this pr a review? Thanks.

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.