search

bridgecrewio / yor

Extensible auto-tagger for your IaC files. The ultimate way to link entities in the cloud back to the codified resource which created it.
https://www.yor.io
Apache License 2.0
818 stars 123 forks source link

Add the ability to set "propagate_at_launch=true" on tags added to aws_autoscaling_group Terraform resources. #502

Closed danielgollas closed 3 months ago

danielgollas commented 6 months ago

Is your feature request related to a problem? Please describe. We use tags to track costs across our infrastructure, linking them back to specific git_repos (using the git tags added by yor). However, EC2 instances launched through an AWS autoscaling group do not receive those tags (and can therefore not be tracked). AWS autoscaling groups have the "propagate_at_launch" property that can be added to individual tag blocks in the aws_autoscaling_group module (but not in a plural "tags" mapping), causing the EC2 instances to get a copy of the specified tags from the autoscaling group.

Describe the solution you'd like Adding tags to autoscaling group resources as individual "tag" blocks (instead of a "tags" mapping) and adding the option to set the "propagate_at_launch" property on them for the standard git tagger would be very useful for tracking dynamically created resources.

Describe alternatives you've considered The workaround is to manually add a tag block to an autoscaling group resource with a static or derived value, without making use of Yor and the repository values it computes, but this is manual and error-prone work.

Additional context Documentation for the propagate_at_launch tag: https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/autoscaling_group#propagate_at_launch

stale[bot] commented 5 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.