search

bridgedb / BridgeDb

The BridgeDb Library source code
https://bridgedb.org/
Apache License 2.0
28 stars 21 forks source link

Datasources.txt, issues loading latest data #112

Closed nunogit closed 5 years ago

nunogit commented 5 years ago

@marvinm2 your last update to the datasources.txt file is creating some issues. It seems to me to be related to the number of fields you added. Can you check, please?

marvinm2 commented 5 years ago

https://github.com/bridgedb/BridgeDb/blob/master/org.bridgedb.bio/resources/org/bridgedb/bio/datasources.txt

Should be fine now! It had spaces instead of tabs, my mistake with pasting

egonw commented 5 years ago

@marvinm2, please run the test suite before you make a pull request ;)

https://jenkins.bigcat.unimaas.nl/job/bridgedb/lastCompletedBuild/testReport/

marvinm2 commented 5 years ago

I didn't know about that, it is why I asked for a review before the merge. I hope it is solved now anyway.

egonw commented 5 years ago

@marvinm2, next time, please give precise instructions of what you expect. For clarity, no worries, these things happen.

BTW, I think I've isolated what went wrong. I do normally compile things, and in the past I learned that Maven doesn't install a bundle if it has test fails. But that never was or no longer is the situation, and since things installed, I assumed the test suite ran fine. It didn't.

egonw commented 5 years ago

@marvinm2, please see the README for explanation on how to run the unit tests.

You almost fixed the problems :)