bridgedb / BridgeDb

The BridgeDb Library source code
https://bridgedb.org/
Apache License 2.0
28 stars 21 forks source link

Bump version to -SNAPSHOT #41

Closed stain closed 7 years ago

stain commented 7 years ago

Why is the pom.xml on the master branch still saying <version>2.2.0</version> even though there's been quite a few commits since 2.2.0? The version should be bumped to 2.2.1-SNAPSHOT or equivalent for all pom.files.

Am I OK to do that?

stain commented 7 years ago

Or is 2.2.0 not yet existing? (no tag) In which case it should clearly say 2.2.0-SNAPSHOT!

egonw commented 7 years ago

No, I was very close to a release, and then ran into the situation that the BridgeDb Derby files did not load in various situations... I will be less sloppy with versioning and even do preparing releases in a branch...

egonw commented 7 years ago

What do you think? "Revert" to 2.2.0-SNAPSHOT or never release 2.2.0 and aim at a 2.2.1 release?

stain commented 7 years ago

Ah, I caught you in the middle of the action.. :) Revert to 2.2.0-SNAPSHOT until the release is ready/tagged?

Usually the mvn release:prepare and mvn release:perform will handle it for you. It can do it on a branch or as master commits with immediately bumps to the next SNAPSHOT (the 2.2.0 commit would never stay at tip).

egonw commented 7 years ago

Is changing the root pom.xml version enough (which I just did)? I guess not...

egonw commented 7 years ago

Those two mvn commands seem useful... new to me (as much of Maven, really)... thanks!

stain commented 7 years ago

Try mvn release:update-versions -DautoVersionSubmodules=true to update all POMs in one go.

See https://maven.apache.org/maven-release/maven-release-plugin/update-versions-mojo.html

stain commented 7 years ago

https://maven.apache.org/maven-release/maven-release-plugin/index.html https://maven.apache.org/maven-release/maven-release-plugin/examples/prepare-release.html https://maven.apache.org/maven-release/maven-release-plugin/examples/perform-release.html

For this to work the <scm> info needs to be up to date (it seems to be)