search

bridgedb / BridgeDbWebservice

BridgeDb Webservice
Apache License 2.0
1 stars 2 forks source link

Update BDBVERSION in pom.xml #28

Closed jmillanacosta closed 6 months ago

jmillanacosta commented 6 months ago

The version of BridgeDB used to build the new docker upon ping from the repo uses the following code to get the BDBVERSION:

https://github.com/bridgedb/docker/blob/fc06a5f214797e0b76a461fee4b7d99a4fe5ae21/.github/workflows/buildandpush.yml#L42C18-L42C92

Meaning this POM needs to be updated too. This patch fixes the issue for now, but what will the workflow be to automate this?

egonw commented 6 months ago

No, it's not supposed to use 3.1.x yet. But when I used :latest that I used did not give me the Jan 2.1.7 release, but this instead:

image

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 65.61%. Comparing base (93e410e) to head (4c838c3).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #28 +/- ## ========================================= Coverage 65.61% 65.61% Complexity 138 138 ========================================= Files 21 21 Lines 791 791 Branches 108 108 ========================================= Hits 519 519 Misses 228 228 Partials 44 44 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.