bridgedb / datasources

Repository with the BridgeDb data source.
Creative Commons Zero v1.0 Universal
4 stars 8 forks source link

example_identifier for SwissProt #11

Closed ariutta closed 3 months ago

ariutta commented 8 years ago

datasources.txt lists CALM_HUMAN as an example_identifier for SwissProt. datasources_headers.txt defines example_identifier as

A valid example of a datasource identifier; may not be representative of all types of identifiers from a given resource 1851_s_at

I discussed this with Nick Juty, and the result was that CALM_HUMAN is an entry name:

The entry name is a useful mnemonic means of identifying a sequence, but, unlike the accession number, it is not a stable identifier.

Further comment from Nick:

I think that the gene name is CALM, and in humans it is CALM_HUMAN. But we use the identifier provided by UniProt for the record, not for the gene or protein. The identifier for the record is the stable identifier.

So is datasources.txt wrong to list CALM_HUMAN as an example identifier for SwissProt? Should the example_identifier instead be P62158?

ariutta commented 8 years ago

The linkout_pattern is http://www.uniprot.org/uniprot/$id, and http://www.uniprot.org/uniprot/CALM_HUMAN does resolve. It forwards to http://www.uniprot.org/uniprot/P62158, which happens to be the same URI we get from the linkout_pattern and example_identifier for the Uniprot-TrEMBL entry in datasources.txt.

egonw commented 3 months ago

I guess this was fixed at some point.