search

bridgedb / datasources

Repository with the BridgeDb data source.
Creative Commons Zero v1.0 Universal
4 stars 8 forks source link

Add Bioregistry prefixes #27

Closed cthoyt closed 2 years ago

cthoyt commented 2 years ago

Closes #22

Not all rows were mappable to the bioregistry. For example, there's a row for "Other" which seems to imply the absence of standardized semantics. Another issue was the "OpenTargets" entry seems to actually be redundant of Ensembl Gene. Some of the other resources (a lot of plant things) were hard to figure out since they were missing important metadata. I'll try that on a second pass.

See also https://github.com/biopragmatics/bioregistry/pull/388, where I added some missing prefixes to the Bioregistry to support this mapping.

cthoyt commented 2 years ago

@egonw not sure what happened but this branch wasn't merged properly?

egonw commented 2 years ago

What did you see that you reach that conclusion?

cthoyt commented 2 years ago

weird since I do see the commits on the main branch

Screen Shot 2022-05-21 at 18 47 57
egonw commented 2 years ago

Oh... I rebased this branch. That probably confused GitHub.

cthoyt commented 2 years ago

Would highly suggest using squash + merge to keep commit histories focused on high-level changes, then the PR is linked automatically and keeps the commit history on GitHub

egonw commented 2 years ago

I have very bad experiences with repeated merges back and forth between PRs and the main branch. Thanks for your recommendation, but not heading down that rabbit hole again.