bridgedb / datasources

Repository with the BridgeDb data source.
Creative Commons Zero v1.0 Universal
4 stars 8 forks source link

Add test that examples match regular expressions #28

Closed cthoyt closed 2 years ago

cthoyt commented 2 years ago

This PR does the following:

  1. Adds a test for each row that has both a regular expression pattern and an example identifier, that the identifier is indeed matched by the regular expression. This identified 4 rows where this was not the case.
  2. Updates the rows where this isn't the case
  3. Runs black, causes a bit of spurious diff, but worth it
egonw commented 2 years ago

Oh, this is going to be a pain. Just for your information. The pain with these PRs is not here in this repo, but with the downstream users, which includes BridgeDb and PathVisio.

cthoyt commented 2 years ago

Yes, this is the same sentiment I've got from many databases when I've tried to help standardize the semantics, but ultimately this is worth doing since it's necessary for interoperability