search

bridgedb / docker

BridgeDb Docker
5 stars 4 forks source link

hardcoded BridgeDb version in setup script #40

Closed egonw closed 7 months ago

egonw commented 1 year ago

https://github.com/bridgedb/docker/blob/db843f727bfcfc038eaa96f26c5d9e52dae90696/setup.sh#L7

I guess this should be discovered in a similar way as the Docker versioning is doing.

egonw commented 1 year ago

It is supposed to be updated in this line:

https://github.com/bridgedb/docker/blob/66a18e5ca8cc4f18d5e6f911c8a53045befedcd9/.github/workflows/buildandpush.yml#L52

But the strings don't match.

jmillanacosta commented 7 months ago

Working, see https://github.com/bridgedb/docker/commit/d0fd2e9137c06367e4c429b5ffa05f3ea87190f4

The script is now pushed at every run if the version number changes