Relocate `Publisher` class functionality to `Resource::Base` concern

bridgetownrb / bridgetown

A next-generation progressive site generator & fullstack framework, powered by Ruby

https://www.bridgetownrb.com

MIT License

1.13k stars 114 forks source link

Relocate `Publisher` class functionality to `Resource::Base` concern #403

Closed jaredcwhite closed 2 years ago

jaredcwhite commented 2 years ago

It seems like a stretch to have this as its own class…really could just be refactored down to one or two methods on site.

armahillo commented 2 years ago

Publisher: https://github.com/bridgetownrb/bridgetown/blob/main/bridgetown-core/lib/bridgetown-core/publisher.rb

Site https://github.com/bridgetownrb/bridgetown/blob/main/bridgetown-core/lib/bridgetown-core/site.rb

jaredcwhite commented 2 years ago

Actually…I believe this is only relevant to resources now, so it can just hang off of Resource::Base!

jaredcwhite commented 2 years ago

Seems like this wasn't fully completed after all, plus there's a missing gap of logic causing the bug of #557. Concerning this wasn't caught by the test suite. Will investigate!