search

briederer / LatSpec.jl

A Julia Package for Lattice Spectroscopy
https://bernd1995.github.io/LatSpec.jl
MIT License
3 stars 1 forks source link

Effective masses #21

Open fzierler opened 3 years ago

fzierler commented 3 years ago

Effective mass for Numbers and DataPoints including error propagation. Still needs tests and requires #20.

briederer commented 3 years ago

First look seems fine to me. Have you also tried building it with the Package mentioned in https://inspirehep.net/literature/1837727 instead of DataPoint from #20?

briederer commented 3 years ago

Also the mentioned package ADerrors.jl seems to be very finished. Maybe we could contact the maintainer and join forces?

fzierler commented 3 years ago

Also the mentioned package ADerrors.jl seems to be very finished. Maybe we could contact the maintainer and join forces?

I tried to use ADerrors.jl for performing the propagation of uncertainty of the effective masses, but the resulting error was always an order of magnitude smaller than with the methods in this PR. It might just be that I do not fully understand the error reduction techniques in ADerrors.jl (I will first need to read the references provided in that repo), but for now I am hesitant to start relying on that package since I have not fully understood it (yet?).

Maybe we should think of this package (at least for now) as a collection to most naive implementations for performing lattice spectroscopy. Once we have this working we can add more sophisticated ways of doing this. I will definitely continue to study the details of ADerrors.jl and I think at some point we might be able to provide error propagation using ADerrors.jl in addition to the naive implementations.

We definitely should mention this package in the README.

briederer commented 3 years ago

I tried to use ADerrors.jl for performing the propagation of uncertainty of the effective masses, but the resulting error was always an order of magnitude smaller than with the methods in this PR. It might just be that I do not fully understand the error reduction techniques in ADerrors.jl (I will first need to read the references provided in that repo), but for now I am hesitant to start relying on that package since I have not fully understood it (yet?).

Okay seems reasonable.

Maybe we should think of this package (at least for now) as a collection to most naive implementations for performing lattice spectroscopy.

By "this package" you mean our package (i.e. LatSpec.jl) am I right?

We definitely should mention this package in the README.

Feel free to add it immediately.

fzierler commented 3 years ago

By "this package" you mean our package (i.e. LatSpec.jl) am I right?

Yes

github-actions[bot] commented 3 years ago

The Docs for this PR are deployed! 🥳 You can find them here.

Please make sure that you have documented your new feature properly:

briederer commented 2 years ago

I guess this would need an adaption to the new PR in #25. Should I merge the current state of this PR into #25 and resolve the differences and close this one? In the end effective masses should be a fundamental feature of LatSpec so it should be fine to have one submit to master where we rework the overall type and add this.

fzierler commented 2 years ago

I guess this would need an adaption to the new PR in #25. Should I merge the current state of this PR into #25 and resolve the differences and close this one? In the end effective masses should be a fundamental feature of LatSpec so it should be fine to have one submit to master where we rework the overall type and add this.

Yes, I think this is a good approach.