briederer / LatSpec.jl

A Julia Package for Lattice Spectroscopy
https://bernd1995.github.io/LatSpec.jl
MIT License
3 stars 1 forks source link

[WIP] Added some math functions and helpers #23

Closed briederer closed 2 years ago

briederer commented 2 years ago

Switched the order of upper and lower error for datapoints because it seems more reasonable to use it in this order (lower,upper).

Added some default constructors and type-specific ones which are needed when calling some functions with DataPoint types as an argument.

Need an opinion by @fzierler on how we treat the systematic uncertainties for things like relative error and region of datapoints.

github-actions[bot] commented 2 years ago

The Docs for this PR are deployed! 🥳 You can find them here.

Please make sure that you have documented your new feature properly:

fzierler commented 2 years ago

Need an opinion by @fzierler on how we treat the systematic uncertainties for things like relative error and region of datapoints.

I don't understand what you mean by that.

briederer commented 2 years ago

Need an opinion by @fzierler on how we treat the systematic uncertainties for things like relative error and region of datapoints.

I don't understand what you mean by that.

I mean if we want to have something like relerror(D::DataPoint) how is the correct way to handle systematic uncertainties? Should we then have one tuple with (stat_err .+ sys_err)./val or return two tuples for the errors independently?

I am also not sure if we even should keep the systematic error after all.

fzierler commented 2 years ago

I am also not sure if we even should keep the systematic error after all.

I agree. Let's get rid of them for now

briederer commented 2 years ago

Moved to #25