"X" to clear search field is gone

brief-rss / brief

RSS reader extension for Firefox

Other

214 stars 44 forks source link

"X" to clear search field is gone #235

Open Araldo-L opened 7 years ago

Araldo-L commented 7 years ago

As there is a "rc" now I tested it (from 2.2.2 before), everything looks working good. Only thing I noted is an issue with the search field on top right. Till version 2.2.2 there was a magnifying glass icon on the right of the search field that turned in an "x" if I entered something to clear the field at once.

As I keep a lot of entries and use search a lot I noticed this immediately. Can you bring it back please?

tanriol commented 7 years ago

Thank you for reporting. Yes, this is a minor regression. Firefox creates these icon buttons automatically for its internal (XUL) search boxes, but, sadly, not for html ones (mozilla bug report). This problem should be possible to work around, although not easy if you want to use platform-native images (moz-icon URLs and such).

tanriol commented 7 years ago

Note to self: the synced tabs sidebar is an XHTML one and has the buttons, see browser/components/syncedtabs/sidebar.xhtml; globally, search for the textbox-search-clear CSS class.