Closed thebat137 closed 6 years ago
tanriol
commented
7 years ago Thank you for this report. Right now Brief still reuses the Firefox built-in feed parser and cannot probably do anything about this bug. However, the WebExtension version will be forced to introduce its own parser anyway and then this will be actionable.
mailtowim
commented
7 years ago You can subscribe to these podcast by first subscribing them with Firefox 'Live Bookmarks' in folder 'Bookmarks menu' > 'Subscribed Feeds'. For me this workaround worked for the podcasts of Разбор Полетов (https://feeds.feedburner.com/razbor-podcast?format=xml).
'Video Podcast' and 'Podcast' are handled as a different content type in firefox than 'Web Feed'. You can see this at about:preferences#general under 'Files and applications'.
mailtowim
commented
7 years ago This bug could be fixed by registering 'application/vnd.mozilla.maybe.video.feed' and 'application/vnd.mozilla.maybe.audio.feed' in bootstrap.js, rather than only application/vnd.mozilla.maybe.feed for the browser fork Palemoon.
Unfortunately it seems this only works in Palemoon, as Firefox is too restrictive. (https://developer.mozilla.org/en-US/docs/Web/API/Navigator/registerContentHandler#Notes)
See bug https://github.com/MoonchildProductions/Pale-Moon/issues/1136
mailtowim
commented
7 years ago You can manually add brief via about:config by adding following string preferences (and this works in Firefox):
For audio podcasts: key: browser.contentHandlers.types.20.title value: Brief key: browser.contentHandlers.types.20.type value: application/vnd.mozilla.maybe.audio.feed key: browser.contentHandlers.types.20.uri value: chrome://brief/content/brief.xhtml?subscribe=%s
For video podcasts: key: browser.contentHandlers.types.21.title value: Brief key: browser.contentHandlers.types.21.type value: application/vnd.mozilla.maybe.video.feed key: browser.contentHandlers.types.21.uri value: chrome://brief/content/brief.xhtml?subscribe=%s
Change the number 20 and 21 to a number slot that is still free.
thebat137
commented
7 years ago @mailtowim, I am not sure how your suggestions address the problem I described in the original issue report. The problem is not that Brief cannot subscribe to these feeds. The problem is that, when they are subscribed to and appear in Brief, new feed entries are not detected by Brief.
mailtowim
commented
7 years ago In Firefox Developer Edition 58, I cannot subscribe to podcasts. The solution was the above. Maybe you have to unsubscribe and subscribe again to these podcasts, so firefox sees them as podcasts, rather than regular feeds.
I have 2 firefox installations (firefox and firefox developer edition.) I am using Brief 2.4 with Firefox Developer Edition. Brief 2.4 seems to be erroneously marked as incompatible with the Developer Edition but I installed it by using the xpi file. Right click in an regular version of firefox on the add button on https://addons.mozilla.org/en-US/firefox/addon/brief/. The resulting xpi file you can drop in a browser window of developer edition and it will ask if you want to install.
I also had an unrelated problem with refreshing in the developer edition, but I fixed it by emptying all tables in brief.sqlite (in your profile folder) with SQLite manager extension in regular firefox. It seems to refresh based on the bookmarks in 'Bookmarks menu' > 'Subscribed Feeds'. Also that extension doesn't work in the developer edition (no workaround).
It seems there are quite some bugs in the new version, but I got to workaround the bugs. I also will upload tomorrow an 'empty' brief.sqlite file with which you can experiment and skip the step with SQlite manager extension. Ofcourse you better make a backup of your feed urls and brief.sqlite, before you start experimenting.
thebat137
commented
7 years ago @mailtowim, I'm still not sure what any of this has to do with the problem of Brief failing to parse feeds it is already subscribed to, which is the problem at the root of this bug report. Can you explain that connection in a little more detali?
Alternately, there are other bug reports (such as issue #261 ) that address issues with subscribing to feeds; perhaps your experiences might be more closely related to one of those?
thebat137
commented
7 years ago @silentbrains, yes, what you describe is exactly what happens with that particular feed for me when I first subscribe to it. The problem is that new entries after the original subscription date are not detected properly. That is why I say it is a parsing issue, not a subscription issue. Also, the other feeds I listed have slightly different types of problems.
mailtowim
commented
7 years ago For the Atheist Talk RSS, I can reproduce the problem. The channel XML element seems to be detected as a separate item on the RSS, while it should be skipped.
I don't seem any errors against the specifications of Apple at: https://help.apple.com/itc/podcasts_connect/#/itcb54353390
thebat137
commented
7 years ago That makes sense, @mailtowim. But I presume the parsing issues are actually with the built-in Firefox feed parser, as @tanriol says above, and so will be beyond the scope of readily available bug fixes until Brief switches to using its own feed parser.
mailtowim
commented
7 years ago For the atheist talk rss it seems it is caused by the unwellformedness of the XML (issue with ampersand), and for this feed, I see an error 'Live Bookmark failed to load'. I guess Firefox will not fix this, because this is an unwellformedness issue.
The other 2 feeds seems to load fine in Firefox Developer Edition Quantum 58b1 and the XML don't contain huge errors. Today Firefox Quantum Edition 57 is released, so that may also solve your issue for the other 2 feeds.
bdcomp
commented
6 years ago I have several feeds (manually added) not showing any item, just "No items" message. For example: https://codeascraft.com/feed/
An additional feed show only the last item.
All these feeds works great as Live Bookmarks.
Does it related to this issue or should I open a new one?
Brief 2.5.5 Firefox 57 Kubuntu 17.10 64bit
tanriol
commented
6 years ago @bdcomp I've just added the feed you referenced to my test profile and it successfully loaded 10 items. Are you sure you don't have the "remove items after N days" setting active?
tanriol
commented
6 years ago @thebat137 For the feeds you initially mentioned:
mailtowim
commented
6 years ago @bdcomp I have had that same issue, but no feed worked. Afterwards I cleaned up my firefox profile and restarted from zero and the bug didn't return, but I did a backup with 'Export feeds' in Brief. I cannot reproduce the bug 'unfortunately' to find the cause. It was probably due to issue #306 .
tanriol
commented
6 years ago I'm closing this bug as there are no action items here and the parsing engine has significantly changed since it was opened. If there are other feeds that don't work, please search for existing bugs or open new ones.
I have a few feeds that have never worked properly with Brief. In each case, the feed is able to be subscribed to, and it looks fine in my browser window, but Brief fails to find some or all of the feed entries. When I put the feeds through the w3c feed validator at https://validator.w3.org/feed/check.cgi, some of them show imperfections, but it seems like these must be correctable, since at least some other feed readers can presumably handle these feeds. The feeds in question are:
Feed 1 does not show any entries at all in Brief. Feed 2 shows the most recent entry, but older entries are not shown, and no entry ever comes up as "unread". Feed 3 is rated as valid by the w3c tool and all older entries are shown in brief, but no entry ever comes up as unread and the most recent feed entry is not shown at all.
I'm not sure if these feeds are all having trouble for the same reasons, given the slightly different error modes, but hopefully someone more knowledgeable than I about how Brief parses feeds can determine this.