brief-rss / brief

RSS reader extension for Firefox
Other
215 stars 44 forks source link

too many spacers being created and no way to remove them #460

Open ghost opened 5 years ago

ghost commented 5 years ago

2.6.0b2 on FF N 69.0a1 (2019-06-03) x_64 on W10 Pro v 1903


when creating new subdirectories via Organize Brief is now generating too many spacers and there seems to be no way to remove those, at least I have not figured it out

spacer

tanriol commented 5 years ago

These spacers are actually subfolder creation / drop on last place handles. Brief normally creates one per directory so that you can create a subfolder in it or drop a feed/folder into it. On your screenshot dev is the parent of master, master is the parent of current and the handles belong to, top to bottom, current, master, dev and dev's parent folder. All the handles/spacers are automatically hidden when not in Organize mode.

The UI is non-ideal, but at the moment I don't have anything better. If you have some ideas, would be cool to hear them. This UI was designed to not require any new strings to avoid localization problems, but now we have new strings anyway so this no longer really matters.

ghost commented 5 years ago

Brief normally creates one per directory so that you can create a subfolder in it or drop a feed/folder into it

That used to be the way but now dropping a feed/folder seems to entail dropping another spacer along with it and thus creating these countless spacers.


All the handles/spacers are automatically hidden when not in Organize mode.

I am afraid it is not, it starts distorting the vertical layout of the sidebar panel

spacer


Of course the functionality of such spacers is not questioned.

The UI is non-ideal, but at the moment I don't have anything better. If you have some ideas, would be cool to hear them.

The UI is fine, at least for me - it does not need to be pitch perfect.

These spacers are actually subfolder creation / drop on last place handles

So if they are just subfolders why not provision its removal via Organize, similar to any other folder that can be deleted one Organize is closed?

tanriol commented 5 years ago

That used to be the way but now dropping a feed/folder seems to entail dropping another spacer along with it and thus creating these countless spacers.

Does it? Dropping a folder should bring with it all its contents, including the final handle, but otherwise it should not create additional spacers.

It may be slightly confusing that in highly nested folders the folder contents, including the final spacer, is indented to the same level as the folder itself so it may seem to be unrelated to it.

I am afraid it is not, it starts distorting the vertical layout of the sidebar panel

Hm, the spacers are correctly hidden in this situation, but the margins add up rather unfortunately. Will need to check the styles in here.

So if they are just subfolders why not provision its removal via Organize, similar to any other folder that can be deleted one Organize is closed?

They are placeholders for subfolders that do not yet exist. It's rather difficult to remove something that does not exist :-) and if it were removed, how would you create subfolders in these folders, and how would you drop something into them?

ghost commented 5 years ago

Dropping a folder should bring with it all its contents, including the final handle, but otherwise it should not create additional spacers.

Right, that how it works indeed.


margins add up rather unfortunately. Will need to check the styles in here.

:+1:


They are placeholders for subfolders that do not yet exist. It's rather difficult to remove something that does not exist :-)

Sure, but it is not thin air either. Preferably those placeholders would be creatable/deletable by the user via an UI menu. But that would likely require some time you do not have to code some script for parsing the necessary html/css...