search

brief-rss / brief

RSS reader extension for Firefox
Other
214 stars 44 forks source link

Can't use keyboard shortcut to open Brief on Firefox on macOS #481

Open ixearth opened 4 years ago

ixearth commented 4 years ago

Brief: 2.6.0 Firefox: 71.0 (64-bit) OS: macOS Catalina 10.15.2

In the Brief keyboard shortcut page, it says "Cmd + Shift + D" to "Open Brief". But "Cmd + Shift + D" is conflicted with Firefox's built-in keyboard shortcut, it's used to Bookmark All Tabs

How does the shortcut works on other platforms? other platforms use "Ctrl + Shift + D" to Bookmark All Tabs and does not conflict with this? Maybe change to "Ctrl + Shift + D" to Open Brief on macOS, or provide an option to change the keyboard shortcut.

btw Can we have . for refresh feeds? or maybe r for refresh current selected feed, R for refresh all feeds.

tanriol commented 4 years ago

I'm not sure whether it worked on macOS at all as I don't have access to one. Anyway, I'd consider going back to Ctrl/Cmd + Alt + D now that this combination is supported for WebExtensions.

For now note that the about:addons has a shortcut manager hidden behind the gear icon that can be used to reassign the shortcut. Yes, this is a non-obvious place for it :-)

tanriol commented 4 years ago

Can we have . for refresh feeds? or maybe r for refresh current selected feed, R for refresh all feeds.

I'd probably prefer some combination, not a single key, but otherwise should be possible.

ixearth commented 4 years ago

Anyway, I'd consider going back to Ctrl/Cmd + Alt + D now that this combination is supported for WebExtensions.

btw Cmd + Alt + D also can't be used for browser extension on macOS, because it's the default macOS shortcut to "Turn Dock Hiding On/Off", but Ctrl + Alt + D should be fine.

For now note that the about:addons has a shortcut manager hidden behind the gear icon that can be used to reassign the shortcut.

Thanks!

ixearth commented 4 years ago

I found the solution, just specific the shortcuts for macOS.

    "commands": {
        "_execute_browser_action": {
            "suggested_key": {
                "default": "Ctrl+Shift+D",
                "mac": "MacCtrl+Shift+D"
            }
        }
    },

On Macs, "Ctrl" is interpreted as "Command", so if you actually need "Ctrl", specify "MacCtrl".

https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/commands

I'd consider going back to Ctrl/Cmd + Alt + D now that this combination is supported for WebExtensions.

Is there any specific reason to change back to Ctrl/Cmd + Alt + D? seems Ctrl+Shift+D is not bad, it's easier to press. But I don't understand why open a new window each time (both the shortcut and press on the icon), why not just only one tab and every time clicking on the icon or press the shortcut just switch to the existing tab? Closing duplicated tabs is a bit annoying.