tanriol
commented
2 years ago While I'm okay with doing this in principle, this is not the right place for FTS filtering. For example, as currently implemented, all actions "for every item in the current view" would apply to items filtered out by the search filter too.
Query has some remains of the old implementation:
Query._ftsMatchesfullTextSearchinQuery._filtersIMHO, it would be better to:- ensure that
Query._directFilter's filter function calls_ftsMatches(or return a separate function with FTS support as this is likely to be a rare case) - implement
_ftsMatches(ideally it would be nice to have query syntax support, but a substring match should work for an initial implementation) - ensure everything else is plumbed so that the value actually gets there.
The reviews asked to fix the search. Normal search in this implementation of access to the database does not work, I did what I could. It may be worth making a limit on the minimum number of characters or starting a search by a button, but on a test base of several hundred records, it worked fine.