search

briefercloud / briefer

Dashboards and notebooks in a single place. Create powerful and flexible dashboards using code, or build beautiful Notion-like notebooks and share them with your team.
https://briefer.cloud
GNU Affero General Public License v3.0
3.62k stars 206 forks source link

Password required when connecting to MySQL Database #35

Open nicolasmnl opened 2 months ago

nicolasmnl commented 2 months ago

Hi guys! First of all, congratulations on becoming open-source!

Second of all, i don't think the password should be required when connecting to a data source, specially locally :) Maybe optional in the case you don't have a password for your local db instance

Let me know what you guys think!

PS: The problem occurred when I tried to connect to my local MySQL Database using Data sources and it kept asking the password even though I don't have one for a simple test instance I use

lucasfcosta commented 2 months ago

Hey @nicolasmnl! Thanks so much for this issue.

I like this idea. I think we could maybe have a toggle there on that screen that disables the password field and add a tooltip saying that we don't recommend using this setting in production.

Do you want to tackle this issue?

I think we should start with a screenshot of the current form and a quick indication/exploration of where that toggle should go.

douglasmnegri commented 2 months ago

Hi! I'd like to work on this issue. Could you please assign it to me?

nicolasmnl commented 2 months ago

Hey @nicolasmnl! Thanks so much for this issue.

I like this idea. I think we could maybe have a toggle there on that screen that disables the password field and add a tooltip saying that we don't recommend using this setting in production.

Do you want to tackle this issue?

I think we should start with a screenshot of the current form and a quick indication/exploration of where that toggle should go.

Hi, Lucas! Yes, I would love to :)

Yep, I think that's a good start too! I'll take a look when I can!

nicolasmnl commented 2 months ago

Hey @nicolasmnl! Thanks so much for this issue.

I like this idea. I think we could maybe have a toggle there on that screen that disables the password field and add a tooltip saying that we don't recommend using this setting in production.

Do you want to tackle this issue?

I think we should start with a screenshot of the current form and a quick indication/exploration of where that toggle should go.

Hi, Lucas! Yes, I would love to :)

Yep, I think that's a good start too! I'll take a look when I can!

Oh, I just saw Douglas' comment! Don't know why i didn't see it at first! So sorry!

I think he can work on that! He'll probably do a better job than me 😁

lucasfcosta commented 1 month ago

Thanks for the collaborative attitude on this one @nicolasmnl - we all appreciate your report and willingness to help 💚

I'm sure @douglasmnegri will help out on this one! Just assigned him the issue!

vieiralucas commented 1 month ago

Hi @douglasmnegri do you still wish to work on this one? Let me know if you don't have the time anymore or if you want some help. Thank you!