briencj / asremlPlus

asremlPlus is an R package that augments the use of 'ASReml-R' and 'ASReml4-R' in fitting mixed models
Other
16 stars 3 forks source link

fix vignette issue #1

Closed courtiol closed 5 years ago

courtiol commented 5 years ago

Hi, I think I have solve the vignette issues. At least it works on my computer. The folder vignette was at the wrong place and I had to do few other minor changes. Check the commit for more details. ++ Alex

briencj commented 5 years ago

Hi Alex,

Thanks for your suggestions. I have merged them into VIgnettes. However, most unfortunately they do not fix the problem on my machine.

From what I can gather the problem is in the VIgnetteBuilder field in the DESCRIPTION file. For some reason the loadVignetteBuilder function, that I am guessing is called in response to the VIgnetteBuilder field, is not able to find R.rsp in my library. I have been unable to figure out why.

Cheers, Chris

courtiol commented 5 years ago

Do you have knitr installed? For some weird reasons it needs it to build vignettes even when they are pre built. I never got to the bottom of why but that did solve the problem on all student laptops failing to build vignettes in a package I did with R.rsp. Let me know if it changes anything. Alex

On Mon, 4 Feb 2019 at 03:01, Chris Brien notifications@github.com wrote:

Hi Alex,

Thanks for your suggestions. I have merged them into VIgnettes. However, most unfortunately they do not fix the problem on my machine.

From what I can gather the problem is in the VIgnetteBuilder field in the DESCRIPTION file. For some reason the loadVignetteBuilder function, that I am guessing is called in response to the VIgnetteBuilder field, is not able to find R.rsp in my library. I have been unable to figure out why.

Cheers, Chris

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/briencj/asremlPlus/pull/1#issuecomment-460111541, or mute the thread https://github.com/notifications/unsubscribe-auth/AHJvkgrxg_HpFGZ6aKawhg6XnJP6LBe4ks5vJ5R3gaJpZM4agGUx .

-- Alexandre Courtiol

http://sites.google.com/site/alexandrecourtiol/home

"Science is the belief in the ignorance of experts", R. Feynman

briencj commented 5 years ago

Hi Alex,

You will be pleased to know that I have managed to get the vignettes working.

I had to update all the packages in my library to get R.rsp to run successfully.

However, to have the vignettes present in \vignettes after install I have had to put them in inst\vignettes. They are then copied to \vignettes and inst\vignettes is deleted when installed.

Thanks for your help,

Cheers,

Chris Brien

3 Rosetta Street COLLINSWOOD 5081 South Australia Phone: +61 8 8269 1485 Email: chris.brien@iinet.net.aumailto:hchris@brien.name

From: Alexandre Courtiol [mailto:notifications@github.com] Sent: Monday, 4 February 2019 5:44 PM To: briencj/asremlPlus Cc: Chris Brien; State change Subject: Re: [briencj/asremlPlus] fix vignette issue (#1)

Do you have knitr installed? For some weird reasons it needs it to build vignettes even when they are pre built. I never got to the bottom of why but that did solve the problem on all student laptops failing to build vignettes in a package I did with R.rsp. Let me know if it changes anything. Alex

On Mon, 4 Feb 2019 at 03:01, Chris Brien notifications@github.com wrote:

Hi Alex,

Thanks for your suggestions. I have merged them into VIgnettes. However, most unfortunately they do not fix the problem on my machine.

From what I can gather the problem is in the VIgnetteBuilder field in the DESCRIPTION file. For some reason the loadVignetteBuilder function, that I am guessing is called in response to the VIgnetteBuilder field, is not able to find R.rsp in my library. I have been unable to figure out why.

Cheers, Chris

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/briencj/asremlPlus/pull/1#issuecomment-460111541, or mute the thread https://github.com/notifications/unsubscribe-auth/AHJvkgrxg_HpFGZ6aKawhg6XnJP6LBe4ks5vJ5R3gaJpZM4agGUx .

-- Alexandre Courtiol

http://sites.google.com/site/alexandrecourtiol/home

"Science is the belief in the ignorance of experts", R. Feynman

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHubhttps://github.com/briencj/asremlPlus/pull/1#issuecomment-460150719, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AMPjFcTHalAn3cdku_TCJyrQEZVKS5djks5vJ93AgaJpZM4agGUx.

courtiol commented 5 years ago

Thanks for letting me know! As long as it works that is great.

Just a thought: personally, I have had too many issues in the past with vignettes, which is why I will progressively move everything to bookdowns. That way you can add tutorials without the need to update a package and since everyone is now connected to the net all the time I don't see major restrictions about doing that.

++ Alex

On Tue, 5 Feb 2019, 14:39 Chris Brien <notifications@github.com wrote:

Hi Alex,

You will be pleased to know that I have managed to get the vignettes working.

I had to update all the packages in my library to get R.rsp to run successfully.

However, to have the vignettes present in \vignettes after install I have had to put them in inst\vignettes. They are then copied to \vignettes and inst\vignettes is deleted when installed.

Thanks for your help,

Cheers,

Chris Brien

3 Rosetta Street COLLINSWOOD 5081 South Australia Phone: +61 8 8269 1485 Email: chris.brien@iinet.net.aumailto:hchris@brien.name

From: Alexandre Courtiol [mailto:notifications@github.com] Sent: Monday, 4 February 2019 5:44 PM To: briencj/asremlPlus Cc: Chris Brien; State change Subject: Re: [briencj/asremlPlus] fix vignette issue (#1)

Do you have knitr installed? For some weird reasons it needs it to build vignettes even when they are pre built. I never got to the bottom of why but that did solve the problem on all student laptops failing to build vignettes in a package I did with R.rsp. Let me know if it changes anything. Alex

On Mon, 4 Feb 2019 at 03:01, Chris Brien notifications@github.com wrote:

Hi Alex,

Thanks for your suggestions. I have merged them into VIgnettes. However, most unfortunately they do not fix the problem on my machine.

From what I can gather the problem is in the VIgnetteBuilder field in the DESCRIPTION file. For some reason the loadVignetteBuilder function, that I am guessing is called in response to the VIgnetteBuilder field, is not able to find R.rsp in my library. I have been unable to figure out why.

Cheers, Chris

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/briencj/asremlPlus/pull/1#issuecomment-460111541, or mute the thread < https://github.com/notifications/unsubscribe-auth/AHJvkgrxg_HpFGZ6aKawhg6XnJP6LBe4ks5vJ5R3gaJpZM4agGUx>

.

-- Alexandre Courtiol

http://sites.google.com/site/alexandrecourtiol/home

"Science is the belief in the ignorance of experts", R. Feynman

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub< https://github.com/briencj/asremlPlus/pull/1#issuecomment-460150719>, or mute the thread< https://github.com/notifications/unsubscribe-auth/AMPjFcTHalAn3cdku_TCJyrQEZVKS5djks5vJ93AgaJpZM4agGUx>.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/briencj/asremlPlus/pull/1#issuecomment-460640685, or mute the thread https://github.com/notifications/unsubscribe-auth/AHJvknOrP0XnETkmSnDT6-TN2v6VMt_uks5vKYl5gaJpZM4agGUx .

briencj commented 5 years ago

I have only just seen bookdowns as I scratch around the web and I hadn’t caught up with them.

Will have a look.

Thanks for the tip,

Chris

From: Alexandre Courtiol [mailto:notifications@github.com] Sent: Wednesday, 6 February 2019 5:10 AM To: briencj/asremlPlus Cc: Chris Brien; State change Subject: Re: [briencj/asremlPlus] fix vignette issue (#1)

Thanks for letting me know! As long as it works that is great.

Just a thought: personally, I have had too many issues in the past with vignettes, which is why I will progressively move everything to bookdowns. That way you can add tutorials without the need to update a package and since everyone is now connected to the net all the time I don't see major restrictions about doing that.

++ Alex

On Tue, 5 Feb 2019, 14:39 Chris Brien <notifications@github.com wrote:

Hi Alex,

You will be pleased to know that I have managed to get the vignettes working.

I had to update all the packages in my library to get R.rsp to run successfully.

However, to have the vignettes present in \vignettes after install I have had to put them in inst\vignettes. They are then copied to \vignettes and inst\vignettes is deleted when installed.

Thanks for your help,

Cheers,

Chris Brien

3 Rosetta Street COLLINSWOOD 5081 South Australia Phone: +61 8 8269 1485 Email: chris.brien@iinet.net.aumailto:hchris@brien.name

From: Alexandre Courtiol [mailto:notifications@github.com] Sent: Monday, 4 February 2019 5:44 PM To: briencj/asremlPlus Cc: Chris Brien; State change Subject: Re: [briencj/asremlPlus] fix vignette issue (#1)

Do you have knitr installed? For some weird reasons it needs it to build vignettes even when they are pre built. I never got to the bottom of why but that did solve the problem on all student laptops failing to build vignettes in a package I did with R.rsp. Let me know if it changes anything. Alex

On Mon, 4 Feb 2019 at 03:01, Chris Brien notifications@github.com wrote:

Hi Alex,

Thanks for your suggestions. I have merged them into VIgnettes. However, most unfortunately they do not fix the problem on my machine.

From what I can gather the problem is in the VIgnetteBuilder field in the DESCRIPTION file. For some reason the loadVignetteBuilder function, that I am guessing is called in response to the VIgnetteBuilder field, is not able to find R.rsp in my library. I have been unable to figure out why.

Cheers, Chris

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/briencj/asremlPlus/pull/1#issuecomment-460111541, or mute the thread < https://github.com/notifications/unsubscribe-auth/AHJvkgrxg_HpFGZ6aKawhg6XnJP6LBe4ks5vJ5R3gaJpZM4agGUx>

.

-- Alexandre Courtiol

http://sites.google.com/site/alexandrecourtiol/home

"Science is the belief in the ignorance of experts", R. Feynman

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub< https://github.com/briencj/asremlPlus/pull/1#issuecomment-460150719>, or mute the thread< https://github.com/notifications/unsubscribe-auth/AMPjFcTHalAn3cdku_TCJyrQEZVKS5djks5vJ93AgaJpZM4agGUx>.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/briencj/asremlPlus/pull/1#issuecomment-460640685, or mute the thread https://github.com/notifications/unsubscribe-auth/AHJvknOrP0XnETkmSnDT6-TN2v6VMt_uks5vKYl5gaJpZM4agGUx .

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHubhttps://github.com/briencj/asremlPlus/pull/1#issuecomment-460753627, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AMPjFYO8PCjJvDDXTVGJ5kH3cEjKUmBXks5vKc_wgaJpZM4agGUx.