brifsttar / OpenDRIVE

Unreal Engine OpenDRIVE plugin
Mozilla Public License 2.0
164 stars 30 forks source link

Build issue when trying to use plugin #16

Open prasuka4 opened 1 year ago

prasuka4 commented 1 year ago

I have tried to add Opendrive plugin in the project library. I have followed the process that was explained in the following issue: https://github.com/brifsttar/OpenDRIVE/issues/15 and also as per document. I'm getting following errors while trying to build. I have tried to resolve but unable to. Could you please have a look and let me know how to solve this issue. Thanks image

OS: Windows 10 UE: 5.0.3 VS: 2019

brifsttar commented 1 year ago

Hey,

Sorry about that, it seems I might have caused this issue. The latest master branch is tested against UE 5.3, and it seems that I'm not very good at ensuring backward compatibility...

And since I'm not very good at tags either, there's not explicit tag for each Unreal release in the history, so I really messed up here.

I think 920878c705 is a commit that should work with 5.0, but I can't test right now. Maybe you can try that on your end, but by rewinding you'll obviously lose some features (you can check the README from that commit to see what was available).

In the future I'll try to better tag for each release and be more explicit about that in the README, sorry.

prasuka4 commented 1 year ago

Hi Thanks for the response, but even the old version is having the same issue and getting the same error. image

brifsttar commented 1 year ago

Are you sure you properly checked out this commit? Because the lines mentioned in the error log don't contain the functions referenced in the log.

https://github.com/brifsttar/OpenDRIVE/blob/920878c705983f72a742a71bfcc3c2ce20210b8b/Source/OpenDRIVE/Private/OpenDriveVehicle.cpp#L36

https://github.com/brifsttar/OpenDRIVE/blob/920878c705983f72a742a71bfcc3c2ce20210b8b/Source/OpenDRIVEEditor/Private/OpenDrive2Landscape.cpp

prasuka4 commented 1 year ago

Thank you, that was a mistake. It was working fine

prasuka4 commented 1 year ago

Hi @brifsttar, I have installed UE version 5.2.1 and tried to visualize the road network after importing xodr file. But i was unable to visualize and can not do any further activity. Could you please help me in solving this issue for editing the road network and also add assets. Thanks in advance image

brifsttar commented 1 year ago

Hi @prasuka4 ,

Have you tried switching to the OpenDRIVE editor mode? It's on the top left drop-down menu, which is set to Selection Mode by default.

prasuka4 commented 1 year ago

image I can not see any open drive editor.

brifsttar commented 1 year ago

Are you on commit 920878c705 as mentioned above? If so, the viewer wasn't available back then.

But if you're now on Unreal 5.2, you should be able to use the master branch which includes that feature.

prasuka4 commented 1 year ago

Hi @brifsttar, Thanks for the response. I was able to view opendrive files in unreal. I have imported a fbx file and xodr file for the same road network generated from roadrunner. But if i try to view in unreal there is difference in scaling and elevation between xodr and scene generated. Is there any reason for this type of behaviour. image

brifsttar commented 1 year ago

That's weird. Are you sure you didn't change the transform on the imported actors? Maybe switch to top view and measure distance (using MMB) to see which between the ODR view and the mesh has the right size.

m8t88 commented 6 months ago

Hi @brifsttar , for various reasons, in my project we are currently stuck on Unreal 5.1.1. I have the same build issue mentioned here and was wondering if you could recomend a commit that was still compatible with Unreal 5.1.1?

brifsttar commented 6 months ago

Hi @m8t88,

I think 45ad41245a405ea61079480509db290a427d9d41 is the last commit that we used with 5.1.

Sorry for the lack of tags and/or version compatibilities, I didn't really have that in mind at the time. I'll try to improve going forward.

m8t88 commented 6 months ago

Hi @brifsttar , thanks a lot for your fast response! Will try it out immediately:)