search

brigadecore / brigade-dashboard

Apache License 2.0
4 stars 5 forks source link

proposal: navbar should stick to the top #59

Closed CIPHERTron closed 2 years ago

CIPHERTron commented 2 years ago

As of now, the navbar doesn't stick to the top which would make it easier for users to navigate between pages. Also, the footer sticks to the bottom which might not be a great from UI/UX perspective according to me

https://user-images.githubusercontent.com/56754747/159470964-287e3eec-4fd7-424d-aec8-9fedc3cea8d0.mov

krancour commented 2 years ago

@CIPHERTron let's treat this as two separate issues.

LEt's have this issue be about the header and I'll open another about the footer.

Let's also discuss this more before deciding it's a bug.

krancour commented 2 years ago

A lot of our design cues have come from GitHub, which you will notice does not have the navbar pinned to the top.

Also, I feel that not pinning it to the top isn't hindering navigability, as most tables are filled with links to "nearby" resources. For instance, when you're looking at a project, there are links to its events right there. If you're looking at an event, there's a link to the project right there. In my own experience using this dashboard so far, I am rarely using the top nav menu.

I'm willing to have this conversation again in the future as the app evolves. Over time, we may find that pinning to the top makes more sense.

In the meantime, I agree on the footer issue and opened #63 to track it.

CIPHERTron commented 2 years ago

I'm willing to have this conversation again in the future as the app evolves. Over time, we may find that pinning to the top makes more sense.

Oh yeah, this was actually my personal preference but your points absolutely make sense. Let's keep this as a proposal and we can discuss about it in the upcoming community meetings maybe?

krancour commented 2 years ago

I'm closing this issue for now.