search

brigadecore / brigade-dashboard

Apache License 2.0
4 stars 5 forks source link

ux: disable logs tabs for unauthorized users #72

Closed DhairyaBahl closed 2 years ago

DhairyaBahl commented 2 years ago

When viewing events/jobs, should gray out log tabs if the user doesn't have access.

Fixes #65.

netlify[bot] commented 2 years ago

Deploy Preview for brigade-dashboard ready!

Name Link
Latest commit c1c0fdcbcf7b938ee314b6ffcd1dc7deea08a4aa
Latest deploy log https://app.netlify.com/sites/brigade-dashboard/deploys/623f77be2759670008fb3856
Deploy Preview https://deploy-preview-72--brigade-dashboard.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

DhairyaBahl commented 2 years ago

@krancour Hii👋 ! I started working on this issue, and I somehow implemented the logic of the issue to check whether the tabs should be grayed out or not. Kindly checkout the logic of the same.

krancour commented 2 years ago

Did some minor cleanup and ran yarn style:fix in 902ac36c29ede7e5b75d57c53dc6704b4c690494

Updated the style of disabled tabs in c1c0fdcbcf7b938ee314b6ffcd1dc7deea08a4aa

krancour commented 2 years ago

/brig run

krancour commented 2 years ago

@DhairyaBahl thanks for this!

Also, please remember the GPG signature on future commits. Thanks!

DhairyaBahl commented 2 years ago

@krancour Will surely take care of GPG signature from next time. 😄