search

brigadecore / brigade-sdk-for-js

JavaScript (and TypeScript) SDK for Brigade v2
Apache License 2.0
4 stars 6 forks source link

Add options arg to all functions that make API calls #57

Closed krancour closed 2 years ago

krancour commented 2 years ago

https://github.com/brigadecore/brigade/pull/1779 had a goal of future-proofing the next major revision of the Go SDK.

This issue calls for changes similar to those found therein, mostly to maintain some kind of parity, since the properties of JavaScript and TypeScript do allow us to add new optional args to a function without breaking existing clients that do not pass those new args.

krancour commented 2 years ago

After further consideration, this just is not necessary.