docker login for all image builds in ci

brigadecore / brigade

Event-driven scripting for Kubernetes

https://brigade.sh/

Apache License 2.0

2.4k stars 247 forks source link

docker login for all image builds in ci #1798

Closed krancour closed 2 years ago

krancour commented 2 years ago

This is a step toward addressing DockerHub rate limiting. Our most frequent pulls are due to the FROM directive in Dockerfiles that we build in our jobs, so logging in before image builds, the way we already do before image pushes is one of the best measures we can take against bumping into the rate limit.

We may still need to do more, but this should be a significant improvement.

netlify[bot] commented 2 years ago

✔️ Deploy Preview for brigade-docs ready!

🔨 Explore the source changes: 6599d57ffe691e6157c0bd2b14ae6422ed1ce292

🔍 Inspect the deploy log: https://app.netlify.com/sites/brigade-docs/deploys/61fadb8402870a0007866db5

😎 Browse the preview: https://deploy-preview-1798--brigade-docs.netlify.app