search

brigadecore / brigade

Event-driven scripting for Kubernetes
https://brigade.sh/
Apache License 2.0
2.4k stars 247 forks source link

docs: update to latest hugo-theme-techdoc #1843

Closed krancour closed 2 years ago

krancour commented 2 years ago

Fixes #1385

This rips out our Frankenstein customizations to the Hugo Techdoc theme and replaces it with the latest version using a submodule. This is apparently how themes are meant to be used.

I've updated our customizations to work with recent changes to the theme. #1385 is fixed in the process. Those customizations are all applied outside the themes/ folder as is recommended.

netlify[bot] commented 2 years ago

✔️ Deploy Preview for brigade-docs ready!

🔨 Explore the source changes: 2efb18ba31ecbab930101a3fcab2ff87bc602c5b

🔍 Inspect the deploy log: https://app.netlify.com/sites/brigade-docs/deploys/62182d21c49429000868490f

😎 Browse the preview: https://deploy-preview-1843--brigade-docs.netlify.app

krancour commented 2 years ago

Noticed some notes around Google Analytics -- I'll defer to @krancour to make sure all is working as expected.

@vdice it is for sure working identically to before. Using the browser's developer tools, I was able to compare before/after and verify that Google Analytics is now incorporated into the site only after a user explicitly consents to cookies -- same as before. The only thing that's up in the air is that I'm missing access to view the collected data, but we'll work that out.